scripts/slave/recipes/chromium_trybot.py - Issue 2146873002: ios: drop dependency on chromium_tests; move analyze to filter module

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_trybot.py

Issue 2146873002: ios: drop dependency on chromium_tests; move analyze to filter module (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipes/chromium_trybot.py

diff --git a/scripts/slave/recipes/chromium_trybot.py b/scripts/slave/recipes/chromium_trybot.py

index 01093b28dce52b90d2fc63aa3c7f0200f44fa725..053899ef3ab1d5ad98563de814f43a671d78eaea 100644

--- a/scripts/slave/recipes/chromium_trybot.py

+++ b/scripts/slave/recipes/chromium_trybot.py

@@ -14,6 +14,7 @@ DEPS = [

'chromium_tests',

'commit_position',

'file',

+ 'filter',

'depot_tools/gclient',

'isolate',

'recipe_engine/json',

@@ -168,11 +169,9 @@ def _RunStepsInternal(api):

all_compile_targets(api, tests + tests_including_triggered)))

additional_compile_targets = sorted(set(compile_targets) -

set(test_targets))

- test_targets, compile_targets = \

- api.chromium_tests.analyze(affected_files,

- test_targets,

- additional_compile_targets,

- 'trybot_analyze_config.json')

+ test_targets, compile_targets = api.filter.analyze(

+ affected_files, test_targets, additional_compile_targets,

+ 'trybot_analyze_config.json')

if bot_config.get('analyze_mode') == 'compile':

tests = []

« no previous file with comments | « scripts/slave/recipe_modules/ios/api.py ('k') | scripts/slave/recipes/findit/chromium/compile.py » ('j') | no next file with comments »