DescriptionAdding checks for V8 functions returning Maybe<bool>
While working on an V8 issue [1], involving adding V8_WARN_UNUSED_RESULT
to functions that were missing it, we discovered that a few calls to
these functions were not using the returned value.
This commit allows compliation to succeed, but in most cases only adds a
comment that something should be done. I'm opening this CL to get
feedback on what the appropriate actions should be.
To try this out I used a .gclient with a custom_deps like this:
u'custom_deps': {
"src/v8":
"git@github.com:danbev/v8.git@064718a8921608eaf9b5eadbb7d734ec04068a87"
},
[1] https://codereview.chromium.org/2135973002/
BUG=
Patch Set 1 #
Total comments: 1
Patch Set 2 : Adding NOTREACHED if Delete result IsNothing for LazyFieldGetterInner #
Total comments: 3
Patch Set 3 : Using v8CallOrCrash for V8 calls in binding sources #Patch Set 4 : Replacing TODOs in module_system.cc with checks. #Patch Set 5 : Add checks for V8 functions returning Maybe<bool> #Patch Set 6 : Adding checks for V8 functions returning Maybe<bool> #Messages
Total messages: 42 (18 generated)
|