Adding checks for V8 functions returning Maybe<bool>

third_party/WebKit/Source/bindings/core/v8/ScriptPromise.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 165 matching lines @@
 {
     if (m_resolver.isEmpty())
         return ScriptPromise();
     return ScriptPromise(m_resolver.getScriptState(), v8Promise());
 }
 
 void ScriptPromise::InternalResolver::resolve(v8::Local<v8::Value> value)
 {
     if (m_resolver.isEmpty())
         return;
-    m_resolver.v8Value().As<v8::Promise::Resolver>()->Resolve(m_resolver.context(), value);
+    if (m_resolver.v8Value().As<v8::Promise::Resolver>()->Resolve(

[haraken, 2016/07/15 02:38:41]

Can you use v8Call macros in V8BindingMacros.h?

You can use v8CallOrCrash to just crash when V8 returns an empty Maybe handle.
The same comment for other files in bindings/.

+        m_resolver.context(), value).IsNothing())
+        return;
     clear();
 }
 
 void ScriptPromise::InternalResolver::reject(v8::Local<v8::Value> value)
 {
     if (m_resolver.isEmpty())
         return;
-    m_resolver.v8Value().As<v8::Promise::Resolver>()->Reject(m_resolver.context(), value);
+    if (m_resolver.v8Value().As<v8::Promise::Resolver>()->Reject(
+        m_resolver.context(), value).IsNothing())
+        return;
     clear();
 }
 
 ScriptPromise::ScriptPromise()
 {
     increaseInstanceCount();
 }
 
 ScriptPromise::ScriptPromise(ScriptState* scriptState, v8::Local<v8::Value> value)
     : m_scriptState(scriptState)
@@ skipping 93 matching lines @@
 }
 
 v8::Local<v8::Promise> ScriptPromise::rejectRaw(ScriptState* scriptState, v8::Local<v8::Value> value)
 {
     if (value.IsEmpty())
         return v8::Local<v8::Promise>();
     v8::Local<v8::Promise::Resolver> resolver;
     if (!v8::Promise::Resolver::New(scriptState->context()).ToLocal(&resolver))
         return v8::Local<v8::Promise>();
     v8::Local<v8::Promise> promise = resolver->GetPromise();
-    resolver->Reject(scriptState->context(), value);
+    if (resolver->Reject(scriptState->context(), value).IsNothing())
+        return v8::Local<v8::Promise>();
     return promise;
 }
 
 ScriptPromise ScriptPromise::all(ScriptState* scriptState, const Vector<ScriptPromise>& promises)
 {
     return PromiseAllHandler::all(scriptState, promises);
 }
 
 void ScriptPromise::increaseInstanceCount()
 {
     // An instance is only counted only on the main thread. This is because the
     // leak detector can detect leaks on the main thread so far. We plan to fix
     // the leak detector to work on worker threads (crbug.com/507224).
     if (isMainThread())
         InstanceCounters::incrementCounter(InstanceCounters::ScriptPromiseCounter);
 }
 
 void ScriptPromise::decreaseInstanceCount()
 {
     if (isMainThread())
         InstanceCounters::decrementCounter(InstanceCounters::ScriptPromiseCounter);
 }
 
 } // namespace blink