third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp - Issue 2144093002: Adding checks for V8 functions returning Maybe<bool>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp

Issue 2144093002: Adding checks for V8 functions returning Maybe<bool> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding checks for V8 functions returning Maybe<bool> Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptPromise.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp

index 37c2aedf0a924ab286ae6b276943d6afe7d4d492..a2e8494c05fd5de75602dd878e9e4cc84079c6c9 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp

@@ -115,10 +115,12 @@ void ScriptPromisePropertyBase::resolveOrRejectInternal(

ASSERT_NOT_REACHED();

break;

case Resolved:

- resolver->Resolve(context, resolvedValue(m_isolate, context->Global()));

+ resolver->Resolve(context, resolvedValue(

+ m_isolate, context->Global())).ToChecked();

break;

case Rejected:

- resolver->Reject(context, rejectedValue(m_isolate, context->Global()));

+ resolver->Reject(context, rejectedValue(

+ m_isolate, context->Global())).ToChecked();

break;

}