extensions/renderer/api_last_error.cc - Issue 2144093002: Adding checks for V8 functions returning Maybe<bool>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/api_last_error.cc

Issue 2144093002: Adding checks for V8 functions returning Maybe<bool> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding checks for V8 functions returning Maybe<bool> Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/api_last_error.cc

diff --git a/extensions/renderer/api_last_error.cc b/extensions/renderer/api_last_error.cc

index 2dafc5e16a2446b916eb904a503d8939f9b6729f..12111d23d1398e4119f452a46b57b618413c12dc 100644

--- a/extensions/renderer/api_last_error.cc

+++ b/extensions/renderer/api_last_error.cc

@@ -143,7 +143,7 @@ void APILastError::ClearError(v8::Local<v8::Context> context,

// This Delete() can fail, but there's nothing to do if it does (the exception

// will be caught by the TryCatch above).

- parent->Delete(context, key);

+ parent->Delete(context, key).ToChecked();

}

} // namespace extensions

« no previous file with comments | « AUTHORS ('k') | extensions/renderer/module_system.cc » ('j') | no next file with comments »