Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

Issue 2144093002: Adding checks for V8 functions returning Maybe<bool> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding checks for V8 functions returning Maybe<bool> Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
index 263c8dd490556c318cd40f4dc2045b4e0108563d..3eeb16655428b4fd52d2a6b07f05dba8e1fb189a 100644
--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
@@ -214,8 +214,10 @@ void V8Window::openerAttributeSetterCustom(
}
// Delete the accessor from the inner object.
- info.Holder()->Delete(isolate->GetCurrentContext(),
- v8AtomicString(isolate, "opener"));
+ if (info.Holder()->Delete(isolate->GetCurrentContext(),
+ v8AtomicString(isolate, "opener")).IsNothing()) {
+ return;
+ }
// Put property on the inner object.
if (info.Holder()->IsObject()) {
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698