Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2139303002: Clean up around methods to enter/exit fullscreen (Closed)

Created:
4 years, 5 months ago by foolip
Modified:
4 years, 5 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-dom_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dcheng, dglazkov+blink, eae+blinkwatch, jam, kinuko+watch, mlamouri+watch-content_chromium.org, mlamouri+watch-blink_chromium.org, nasko+codewatch_chromium.org, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up around methods to enter/exit fullscreen https://codereview.chromium.org/2008873004 removed the Element argument for Fullscreen::didExitFullScreenForElement, so now remove it from the method name as well. Remove the dummy boolean return values for WebFrameClient. Also lowercase the S in {will,did}{Enter,Exit}FullScreen everywhere. R=alexmos@chromium.org,jochen@chromium.org BUG=402421 Committed: https://crrev.com/7310137bc63e5d32d849cdab19e4b8bff586ad69 Cr-Commit-Position: refs/heads/master@{#405078}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -71 lines) Patch
M content/renderer/render_frame_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/renderer/render_frame_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Fullscreen.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Fullscreen.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/FullscreenController.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/FullscreenController.cpp View 6 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebRemoteFrameImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewFrameWidget.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewFrameWidget.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 13 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 1 chunk +5 lines, -8 lines 0 comments Download
M third_party/WebKit/public/web/WebRemoteFrame.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/web/WebView.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebWidget.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
foolip
4 years, 5 months ago (2016-07-12 14:13:19 UTC) #1
foolip
Link to issue 402421 is just because that's what I was working on, and it's ...
4 years, 5 months ago (2016-07-12 15:00:03 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-07-12 16:03:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2139303002/1
4 years, 5 months ago (2016-07-12 16:05:32 UTC) #9
alexmos
LGTM, thanks for the cleanup!
4 years, 5 months ago (2016-07-12 16:32:52 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/191425)
4 years, 5 months ago (2016-07-12 17:37:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2139303002/1
4 years, 5 months ago (2016-07-12 18:18:50 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/191766)
4 years, 5 months ago (2016-07-12 23:36:16 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2139303002/1
4 years, 5 months ago (2016-07-13 07:42:06 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 08:19:36 UTC) #19
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 08:19:52 UTC) #20
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 08:21:21 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7310137bc63e5d32d849cdab19e4b8bff586ad69
Cr-Commit-Position: refs/heads/master@{#405078}

Powered by Google App Engine
This is Rietveld 408576698