Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Side by Side Diff: third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

Issue 2139303002: Clean up around methods to enter/exit fullscreen (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "web/WebRemoteFrameImpl.h" 5 #include "web/WebRemoteFrameImpl.h"
6 6
7 #include "core/dom/Fullscreen.h" 7 #include "core/dom/Fullscreen.h"
8 #include "core/dom/RemoteSecurityContext.h" 8 #include "core/dom/RemoteSecurityContext.h"
9 #include "core/dom/SecurityContext.h" 9 #include "core/dom/SecurityContext.h"
10 #include "core/frame/FrameView.h" 10 #include "core/frame/FrameView.h"
(...skipping 506 matching lines...) Expand 10 before | Expand all | Expand 10 after
517 } 517 }
518 518
519 bool WebRemoteFrameImpl::isIgnoredForHitTest() const 519 bool WebRemoteFrameImpl::isIgnoredForHitTest() const
520 { 520 {
521 HTMLFrameOwnerElement* owner = frame()->deprecatedLocalOwner(); 521 HTMLFrameOwnerElement* owner = frame()->deprecatedLocalOwner();
522 if (!owner || !owner->layoutObject()) 522 if (!owner || !owner->layoutObject())
523 return false; 523 return false;
524 return owner->layoutObject()->style()->pointerEvents() == PE_NONE; 524 return owner->layoutObject()->style()->pointerEvents() == PE_NONE;
525 } 525 }
526 526
527 void WebRemoteFrameImpl::willEnterFullScreen() 527 void WebRemoteFrameImpl::willEnterFullscreen()
528 { 528 {
529 // This should only ever be called when the FrameOwner is local. 529 // This should only ever be called when the FrameOwner is local.
530 HTMLFrameOwnerElement* ownerElement = toHTMLFrameOwnerElement(frame()->owner ()); 530 HTMLFrameOwnerElement* ownerElement = toHTMLFrameOwnerElement(frame()->owner ());
531 531
532 // Call requestFullscreen() on |ownerElement| to make it the provisional 532 // Call requestFullscreen() on |ownerElement| to make it the provisional
533 // fullscreen element in FullscreenController, and to prepare 533 // fullscreen element in FullscreenController, and to prepare
534 // fullscreenchange events that will need to fire on it and its (local) 534 // fullscreenchange events that will need to fire on it and its (local)
535 // ancestors. The events will be triggered if/when fullscreen is entered. 535 // ancestors. The events will be triggered if/when fullscreen is entered.
536 // 536 //
537 // Passing |forCrossProcessAncestor| to requestFullscreen is necessary 537 // Passing |forCrossProcessAncestor| to requestFullscreen is necessary
(...skipping 11 matching lines...) Expand all
549 549
550 WebRemoteFrameImpl::WebRemoteFrameImpl(WebTreeScopeType scope, WebRemoteFrameCli ent* client) 550 WebRemoteFrameImpl::WebRemoteFrameImpl(WebTreeScopeType scope, WebRemoteFrameCli ent* client)
551 : WebRemoteFrame(scope) 551 : WebRemoteFrame(scope)
552 , m_frameClient(RemoteFrameClientImpl::create(this)) 552 , m_frameClient(RemoteFrameClientImpl::create(this))
553 , m_client(client) 553 , m_client(client)
554 , m_selfKeepAlive(this) 554 , m_selfKeepAlive(this)
555 { 555 {
556 } 556 }
557 557
558 } // namespace blink 558 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebRemoteFrameImpl.h ('k') | third_party/WebKit/Source/web/WebViewFrameWidget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698