Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: third_party/WebKit/Source/web/FullscreenController.cpp

Issue 2139303002: Clean up around methods to enter/exit fullscreen (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/FullscreenController.cpp
diff --git a/third_party/WebKit/Source/web/FullscreenController.cpp b/third_party/WebKit/Source/web/FullscreenController.cpp
index 39914a73940dcf01d9f2124f027be96f377eb904..6e143691a96d5526b41ca1c14d4750c2d4a0dc0d 100644
--- a/third_party/WebKit/Source/web/FullscreenController.cpp
+++ b/third_party/WebKit/Source/web/FullscreenController.cpp
@@ -60,7 +60,7 @@ FullscreenController::FullscreenController(WebViewImpl* webViewImpl)
{
}
-void FullscreenController::didEnterFullScreen()
+void FullscreenController::didEnterFullscreen()
{
if (!m_provisionalFullScreenElement)
return;
@@ -81,7 +81,7 @@ void FullscreenController::didEnterFullScreen()
m_haveEnteredFullscreen = true;
}
- Fullscreen::from(document).didEnterFullScreenForElement(element);
+ Fullscreen::from(document).didEnterFullscreenForElement(element);
DCHECK_EQ(Fullscreen::currentFullScreenElementFrom(document), element);
if (isHTMLVideoElement(element)) {
@@ -91,7 +91,7 @@ void FullscreenController::didEnterFullScreen()
}
}
-void FullscreenController::didExitFullScreen()
+void FullscreenController::didExitFullscreen()
{
if (!m_fullScreenFrame)
return;
@@ -120,7 +120,7 @@ void FullscreenController::didExitFullScreen()
m_webViewImpl->setVisualViewportOffset(m_exitFullscreenVisualViewportOffset);
}
- fullscreen->didExitFullScreenForElement();
+ fullscreen->didExitFullscreen();
}
}
}
@@ -140,11 +140,11 @@ void FullscreenController::enterFullScreenForElement(Element* element)
// We are already in fullscreen mode.
if (m_fullScreenFrame) {
m_provisionalFullScreenElement = element;
- didEnterFullScreen();
+ didEnterFullscreen();
return;
}
- // We need to store these values here rather than didEnterFullScreen since
+ // We need to store these values here rather than didEnterFullscreen since
// by the time the latter is called, a Resize has already occured, clamping
// the scroll offset.
if (!m_haveEnteredFullscreen) {
@@ -216,4 +216,3 @@ DEFINE_TRACE(FullscreenController)
}
} // namespace blink
-
« no previous file with comments | « third_party/WebKit/Source/web/FullscreenController.h ('k') | third_party/WebKit/Source/web/WebFrameWidgetImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698