Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: third_party/WebKit/public/web/WebFrameClient.h

Issue 2139303002: Clean up around methods to enter/exit fullscreen (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/tests/WebViewTest.cpp ('k') | third_party/WebKit/public/web/WebRemoteFrame.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/web/WebFrameClient.h
diff --git a/third_party/WebKit/public/web/WebFrameClient.h b/third_party/WebKit/public/web/WebFrameClient.h
index 3c34e68ed93ce0067fb51806d53bbed9d02398a0..2aef5e03636db100ab7064823231491f29f3c6ea 100644
--- a/third_party/WebKit/public/web/WebFrameClient.h
+++ b/third_party/WebKit/public/web/WebFrameClient.h
@@ -654,14 +654,11 @@ public:
// Fullscreen ----------------------------------------------------------
// Called to enter/exit fullscreen mode.
- // After calling enterFullscreen, WebWidget::{will,Did}EnterFullScreen
- // should bound resizing the WebWidget into fullscreen mode.
- // Similarly, when exitFullScreen is called,
- // WebWidget::{will,Did}ExitFullScreen should bound resizing the WebWidget
- // out of fullscreen mode.
- // Note: the return value is ignored.
- virtual bool enterFullscreen() { return false; }
- virtual bool exitFullscreen() { return false; }
+ // After calling enterFullscreen or exitFullscreen,
+ // WebWidget::didEnterFullscreen or WebWidget::didExitFullscreen
+ // respectively will be called once the fullscreen mode has changed.
+ virtual void enterFullscreen() { }
+ virtual void exitFullscreen() { }
// Sudden termination --------------------------------------------------
« no previous file with comments | « third_party/WebKit/Source/web/tests/WebViewTest.cpp ('k') | third_party/WebKit/public/web/WebRemoteFrame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698