Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: third_party/WebKit/Source/core/dom/Fullscreen.cpp

Issue 2139303002: Clean up around methods to enter/exit fullscreen (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Fullscreen.cpp
diff --git a/third_party/WebKit/Source/core/dom/Fullscreen.cpp b/third_party/WebKit/Source/core/dom/Fullscreen.cpp
index 030f37b40bfab05f500cbca80fb27e088fde4520..ca15b5bc5b34d1c022d9d11b5f7c1c46af4451de 100644
--- a/third_party/WebKit/Source/core/dom/Fullscreen.cpp
+++ b/third_party/WebKit/Source/core/dom/Fullscreen.cpp
@@ -483,7 +483,7 @@ bool Fullscreen::fullscreenEnabled(Document& document)
return fullscreenIsAllowedForAllOwners(document) && fullscreenIsSupported(document);
}
-void Fullscreen::didEnterFullScreenForElement(Element* element)
+void Fullscreen::didEnterFullscreenForElement(Element* element)
{
DCHECK(element);
if (!document()->isActive())
@@ -533,7 +533,7 @@ void Fullscreen::didEnterFullScreenForElement(Element* element)
m_eventQueueTimer.startOneShot(0, BLINK_FROM_HERE);
}
-void Fullscreen::didExitFullScreenForElement()
+void Fullscreen::didExitFullscreen()
{
if (!m_fullScreenElement)
return;
@@ -610,7 +610,7 @@ void Fullscreen::enqueueChangeEvent(Document& document, RequestType requestType)
event = createEvent(EventTypeNames::webkitfullscreenchange, *target);
}
m_eventQueue.append(event);
- // NOTE: The timer is started in didEnterFullScreenForElement/didExitFullScreenForElement.
+ // NOTE: The timer is started in didEnterFullscreenForElement/didExitFullscreen.
}
void Fullscreen::enqueueErrorEvent(Element& element, RequestType requestType)
« no previous file with comments | « third_party/WebKit/Source/core/dom/Fullscreen.h ('k') | third_party/WebKit/Source/web/FullscreenController.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698