[Extensions] Code Cleanup - Remove redundant smart-ptr get()s

[Extensions] Code Cleanup - Remove redundant smart-ptr get()s

Given std::unique_ptr<T> t, t.get()-> is the same as t->.
Similarly, *t.get() is the same as *t. Simplify extensions
code to conform.

BUG=None

Committed: https://crrev.com/e842df6a33a41f352d75f84b09935766f4f58b69
Cr-Commit-Position: refs/heads/master@{#405277}

[Devlin, 2016-07-12 18:07:44]

Description was changed from

==========
[Extensions] Code Cleanup - Remove redundant smart-ptr get()s

BUG=None
==========

to

==========
[Extensions] Code Cleanup - Remove redundant smart-ptr get()s

Given std::unique_ptr<T> t, t.get()-> is the same as t->.
Similarly, *t.get() is the same as *t. Simplify extensions
code to conform.

BUG=None
==========

[Devlin, 2016-07-12 18:07:44]

rdevlin.cronin@chromium.org changed reviewers:
+ asargent@chromium.org

[Devlin, 2016-07-12 18:08:09]

Simple cleanup. :)

[asargent_no_longer_on_chrome, 2016-07-12 22:30:59]

lgtm

BTW, did you find these with something like clang-tidy, or just find them "by
hand" (eg with text/regex search)?

[Devlin, 2016-07-12 22:33:06]

On 2016/07/12 22:30:59, Antony Sargent wrote:
> lgtm
> 
> BTW, did you find these with something like clang-tidy, or just find them "by
> hand" (eg with text/regex search)?

clang-tidy.  I'm fooling around with it for fun and trying to figure it out.

I'm in the process of adding documentation for it at
https://codereview.chromium.org/2139883002/, and was then gonna share with the
team. :)

[Devlin, 2016-07-13 19:00:27]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-07-13 19:02:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 20:27:56]

Description was changed from

==========
[Extensions] Code Cleanup - Remove redundant smart-ptr get()s

Given std::unique_ptr<T> t, t.get()-> is the same as t->.
Similarly, *t.get() is the same as *t. Simplify extensions
code to conform.

BUG=None
==========

to

==========
[Extensions] Code Cleanup - Remove redundant smart-ptr get()s

Given std::unique_ptr<T> t, t.get()-> is the same as t->.
Similarly, *t.get() is the same as *t. Simplify extensions
code to conform.

BUG=None
==========

[commit-bot: I haz the power, 2016-07-13 20:27:57]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-13 20:28:01]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 20:31:14]

Description was changed from

==========
[Extensions] Code Cleanup - Remove redundant smart-ptr get()s

Given std::unique_ptr<T> t, t.get()-> is the same as t->.
Similarly, *t.get() is the same as *t. Simplify extensions
code to conform.

BUG=None
==========

to

==========
[Extensions] Code Cleanup - Remove redundant smart-ptr get()s

Given std::unique_ptr<T> t, t.get()-> is the same as t->.
Similarly, *t.get() is the same as *t. Simplify extensions
code to conform.

BUG=None

Committed: https://crrev.com/e842df6a33a41f352d75f84b09935766f4f58b69
Cr-Commit-Position: refs/heads/master@{#405277}
==========

[commit-bot: I haz the power, 2016-07-13 20:31:15]

Patchset 1 (id:??) landed as
https://crrev.com/e842df6a33a41f352d75f84b09935766f4f58b69
Cr-Commit-Position: refs/heads/master@{#405277}