extensions/browser/api/alarms/alarm_manager.cc - Issue 2137013005: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/alarms/alarm_manager.cc

Issue 2137013005: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/api/alarms/alarm_manager.cc

diff --git a/extensions/browser/api/alarms/alarm_manager.cc b/extensions/browser/api/alarms/alarm_manager.cc

index 9d1493abd734cad39f112070c1d72d3c56a3296f..626c4ce6698f2650ae73c8f28f8ceb788c02c750 100644

--- a/extensions/browser/api/alarms/alarm_manager.cc

+++ b/extensions/browser/api/alarms/alarm_manager.cc

@@ -258,7 +258,7 @@ void AlarmManager::RemoveAlarmIterator(const AlarmIterator& iter) {

void AlarmManager::OnAlarm(AlarmIterator it) {

CHECK(it.first != alarms_.end());

- Alarm& alarm = *it.second->get();

+ Alarm& alarm = **it.second;

std::string extension_id_copy(it.first->first);

delegate_->OnAlarm(extension_id_copy, alarm);

« no previous file with comments | « no previous file | extensions/browser/api/app_window/app_window_api.cc » ('j') | no next file with comments »