extensions/browser/value_store/value_store_frontend.cc - Issue 2137013005: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/value_store/value_store_frontend.cc

Issue 2137013005: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/guest_view/mime_handler_view/test_mime_handler_view_guest.cc ('k') | extensions/renderer/dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/value_store/value_store_frontend.cc

diff --git a/extensions/browser/value_store/value_store_frontend.cc b/extensions/browser/value_store/value_store_frontend.cc

index ccd50403706c9dee3c3ec504b080914851ce644e..964fdbe022a5387a9822335d0088335a7d79113d 100644

--- a/extensions/browser/value_store/value_store_frontend.cc

+++ b/extensions/browser/value_store/value_store_frontend.cc

@@ -50,9 +50,8 @@ class ValueStoreFrontend::Backend : public base::RefCountedThreadSafe<Backend> {

LazyInit();

// We don't need the old value, so skip generating changes.

ValueStore::WriteResult result = storage_->Set(

- ValueStore::IGNORE_QUOTA | ValueStore::NO_GENERATE_CHANGES,

- key,

- *value.get());

+ ValueStore::IGNORE_QUOTA | ValueStore::NO_GENERATE_CHANGES, key,

+ *value);

LOG_IF(ERROR, !result->status().ok()) << "Error while writing " << key

<< " to " << db_path_.value();

}