extensions/browser/api/device_permissions_manager.cc - Issue 2137013005: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/device_permissions_manager.cc

Issue 2137013005: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/cast_channel/cast_framer.cc ('k') | extensions/browser/api/document_scan/document_scan_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/device_permissions_manager.cc

diff --git a/extensions/browser/api/device_permissions_manager.cc b/extensions/browser/api/device_permissions_manager.cc

index 9320b330b7c1d5c80aafc28421d0eccfd9026bef..7a6dac2d86da4cc152c3ef5229d626cf2b746465 100644

--- a/extensions/browser/api/device_permissions_manager.cc

+++ b/extensions/browser/api/device_permissions_manager.cc

@@ -101,7 +101,7 @@ void SaveDevicePermissionEntry(BrowserContext* context,

}

std::unique_ptr<base::Value> device_entry(entry->ToValue());

- DCHECK(devices->Find(*device_entry.get()) == devices->end());

+ DCHECK(devices->Find(*device_entry) == devices->end());

devices->Append(std::move(device_entry));

}

« no previous file with comments | « extensions/browser/api/cast_channel/cast_framer.cc ('k') | extensions/browser/api/document_scan/document_scan_api.cc » ('j') | no next file with comments »