extensions/browser/api/cast_channel/cast_framer.cc - Issue 2137013005: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/cast_channel/cast_framer.cc

Issue 2137013005: [Extensions] Code Cleanup - Remove redundant smart-ptr get()s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/cast_channel/cast_channel_api.cc ('k') | extensions/browser/api/device_permissions_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/cast_channel/cast_framer.cc

diff --git a/extensions/browser/api/cast_channel/cast_framer.cc b/extensions/browser/api/cast_channel/cast_framer.cc

index c0dec4957b6ca41c1389e102d8fde0c3b7c8d935..e4534159deb8c6403d9c94a92f8d23f73ea78b6d 100644

--- a/extensions/browser/api/cast_channel/cast_framer.cc

+++ b/extensions/browser/api/cast_channel/cast_framer.cc

@@ -133,8 +133,7 @@ std::unique_ptr<CastMessage> MessageFramer::Ingest(size_t num_bytes,

case HEADER:

if (BytesRequested() == 0) {

MessageHeader header;

- MessageHeader::Deserialize(input_buffer_.get()->StartOfBuffer(),

- &header);

+ MessageHeader::Deserialize(input_buffer_->StartOfBuffer(), &header);

if (header.message_size > MessageHeader::max_message_size()) {

VLOG(1) << "Error parsing header (message size too large).";

*error = CHANNEL_ERROR_INVALID_MESSAGE;

« no previous file with comments | « extensions/browser/api/cast_channel/cast_channel_api.cc ('k') | extensions/browser/api/device_permissions_manager.cc » ('j') | no next file with comments »