[Extensions] Break up BaseFeatureProvider, create JSONFeatureProvider

[Extensions] Break up BaseFeatureProvider, create JSONFeatureProvider

BaseFeatureProvider is currently the only implementation of
FeatureProvider (despite its name implying there should be more). As we
move to generated code for Features, pulling the code to vend features
away from the code to populate from a JSON file is necessary.

Pull the parsing/population code out of BaseFeatureProvider into a
JSONFeatureProvider class, inheriting from BaseFeatureProvider (which
maintains the code for returning features). Generated FeatureProviders
will also inherit from BaseFeatureProvider.

BUG=280286
Committed: https://crrev.com/b649a668b8a7df5326ba493cd1c9baf0c3674075
Cr-Commit-Position: refs/heads/master@{#405162}

[Devlin, 2016-07-08 20:39:14]

Patchset #1 (id:1) has been deleted

[Devlin, 2016-07-08 20:39:56]

rdevlin.cronin@chromium.org changed reviewers:
+ asargent@chromium.org

[Devlin, 2016-07-08 20:39:57]

Necessary step for feature generation (see description/doc).  Figured it was
nicer to pull out some pieces like this rather than have a gigantic CL. :)

[asargent_no_longer_on_chrome, 2016-07-11 22:39:20]

lgtm

https://codereview.chromium.org/2133783002/diff/20001/extensions/common/featu...
File extensions/common/features/base_feature_provider.h (right):

https://codereview.chromium.org/2133783002/diff/20001/extensions/common/featu...
extensions/common/features/base_feature_provider.h:19: class BaseFeatureProvider
: public FeatureProvider {
nit: this could use a brief class overview comment (what is a feature provider?
etc.)

[Devlin, 2016-07-12 00:45:29]

https://codereview.chromium.org/2133783002/diff/20001/extensions/common/featu...
File extensions/common/features/base_feature_provider.h (right):

https://codereview.chromium.org/2133783002/diff/20001/extensions/common/featu...
extensions/common/features/base_feature_provider.h:19: class BaseFeatureProvider
: public FeatureProvider {
On 2016/07/11 22:39:20, Antony Sargent wrote:
> nit: this could use a brief class overview comment (what is a feature
provider?
> etc.)

Done.

[Devlin, 2016-07-12 00:45:43]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-07-12 00:45:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/2133783002/#ps60001
(title: "Latest master")

[commit-bot: I haz the power, 2016-07-12 00:46:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 02:03:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 02:03:52]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Devlin, 2016-07-12 04:38:59]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-07-12 04:39:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 08:43:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 08:43:15]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Devlin, 2016-07-12 14:48:55]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-07-12 14:49:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 18:57:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 18:57:10]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Devlin, 2016-07-12 19:00:20]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-07-12 19:03:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 01:08:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 01:08:03]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Devlin, 2016-07-13 15:01:28]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-07-13 15:02:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 15:36:19]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-07-13 15:38:23]

Description was changed from

==========
[Extensions] Break up BaseFeatureProvider, create JSONFeatureProvider

BaseFeatureProvider is currently the only implementation of
FeatureProvider (despite its name implying there should be more). As we
move to generated code for Features, pulling the code to vend features
away from the code to populate from a JSON file is necessary.

Pull the parsing/population code out of BaseFeatureProvider into a
JSONFeatureProvider class, inheriting from BaseFeatureProvider (which
maintains the code for returning features). Generated FeatureProviders
will also inherit from BaseFeatureProvider.

BUG=280286
==========

to

==========
[Extensions] Break up BaseFeatureProvider, create JSONFeatureProvider

BaseFeatureProvider is currently the only implementation of
FeatureProvider (despite its name implying there should be more). As we
move to generated code for Features, pulling the code to vend features
away from the code to populate from a JSON file is necessary.

Pull the parsing/population code out of BaseFeatureProvider into a
JSONFeatureProvider class, inheriting from BaseFeatureProvider (which
maintains the code for returning features). Generated FeatureProviders
will also inherit from BaseFeatureProvider.

BUG=280286

Committed: https://crrev.com/b649a668b8a7df5326ba493cd1c9baf0c3674075
Cr-Commit-Position: refs/heads/master@{#405162}
==========

[commit-bot: I haz the power, 2016-07-13 15:38:24]

Patchset 3 (id:??) landed as
https://crrev.com/b649a668b8a7df5326ba493cd1c9baf0c3674075
Cr-Commit-Position: refs/heads/master@{#405162}