[Extensions] Break up BaseFeatureProvider, create JSONFeatureProvider

chrome/common/extensions/chrome_extensions_client.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/chrome_extensions_client.h"
 
 #include <memory>
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
@@ skipping 16 matching lines @@
 #include "components/version_info/version_info.h"
 #include "content/public/common/url_constants.h"
 #include "extensions/common/api/generated_schemas.h"
 #include "extensions/common/common_manifest_handlers.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/extension_api.h"
 #include "extensions/common/extension_icon_set.h"
 #include "extensions/common/extension_urls.h"
 #include "extensions/common/features/api_feature.h"
-#include "extensions/common/features/base_feature_provider.h"
 #include "extensions/common/features/behavior_feature.h"
 #include "extensions/common/features/feature_provider.h"
+#include "extensions/common/features/json_feature_provider.h"
 #include "extensions/common/features/json_feature_provider_source.h"
 #include "extensions/common/features/manifest_feature.h"
 #include "extensions/common/features/permission_feature.h"
 #include "extensions/common/features/simple_feature.h"
 #include "extensions/common/manifest_constants.h"
 #include "extensions/common/manifest_handler.h"
 #include "extensions/common/manifest_handlers/icons_handler.h"
 #include "extensions/common/permissions/api_permission_set.h"
 #include "extensions/common/permissions/permissions_info.h"
 #include "extensions/common/url_pattern.h"
@@ skipping 90 matching lines @@
 const std::string ChromeExtensionsClient::GetProductName() {
   return l10n_util::GetStringUTF8(IDS_PRODUCT_NAME);
 }
 
 std::unique_ptr<FeatureProvider> ChromeExtensionsClient::CreateFeatureProvider(
     const std::string& name) const {
   std::unique_ptr<FeatureProvider> provider;
   std::unique_ptr<JSONFeatureProviderSource> source(
       CreateFeatureProviderSource(name));
   if (name == "api") {
-    provider.reset(new BaseFeatureProvider(source->dictionary(),
+    provider.reset(new JSONFeatureProvider(source->dictionary(),
                                            CreateFeature<APIFeature>));
   } else if (name == "manifest") {
-    provider.reset(new BaseFeatureProvider(source->dictionary(),
+    provider.reset(new JSONFeatureProvider(source->dictionary(),
                                            CreateFeature<ManifestFeature>));
   } else if (name == "permission") {
-    provider.reset(new BaseFeatureProvider(source->dictionary(),
+    provider.reset(new JSONFeatureProvider(source->dictionary(),
                                            CreateFeature<PermissionFeature>));
   } else if (name == "behavior") {
-    provider.reset(new BaseFeatureProvider(source->dictionary(),
+    provider.reset(new JSONFeatureProvider(source->dictionary(),
                                            CreateFeature<BehaviorFeature>));
   } else {
     NOTREACHED();
   }
   return provider;
 }
 
 std::unique_ptr<JSONFeatureProviderSource>
 ChromeExtensionsClient::CreateFeatureProviderSource(
     const std::string& name) const {
@@ skipping 207 matching lines @@
     const {
   return GetCurrentChannel() == version_info::Channel::UNKNOWN;
 }
 
 // static
 ChromeExtensionsClient* ChromeExtensionsClient::GetInstance() {
   return g_client.Pointer();
 }
 
 }  // namespace extensions