chrome/common/extensions/chrome_extensions_client.cc - Issue 2133783002: [Extensions] Break up BaseFeatureProvider, create JSONFeatureProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/chrome_extensions_client.cc

Issue 2133783002: [Extensions] Break up BaseFeatureProvider, create JSONFeatureProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Latest master Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/common_extension_api_unittest.cc ('k') | chrome/common/extensions/features/chrome_channel_feature_filter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/chrome_extensions_client.cc

diff --git a/chrome/common/extensions/chrome_extensions_client.cc b/chrome/common/extensions/chrome_extensions_client.cc

index d83395475bf6118811f320bda222854a4332872b..5d3b71712eef5854dbc895ccf769987220ad8e78 100644

--- a/chrome/common/extensions/chrome_extensions_client.cc

+++ b/chrome/common/extensions/chrome_extensions_client.cc

@@ -34,9 +34,9 @@

#include "extensions/common/extension_icon_set.h"

#include "extensions/common/extension_urls.h"

#include "extensions/common/features/api_feature.h"

-#include "extensions/common/features/base_feature_provider.h"

#include "extensions/common/features/behavior_feature.h"

#include "extensions/common/features/feature_provider.h"

+#include "extensions/common/features/json_feature_provider.h"

#include "extensions/common/features/json_feature_provider_source.h"

#include "extensions/common/features/manifest_feature.h"

#include "extensions/common/features/permission_feature.h"

@@ -147,16 +147,16 @@ std::unique_ptr<FeatureProvider> ChromeExtensionsClient::CreateFeatureProvider(

std::unique_ptr<JSONFeatureProviderSource> source(

CreateFeatureProviderSource(name));

if (name == "api") {

- provider.reset(new BaseFeatureProvider(source->dictionary(),

+ provider.reset(new JSONFeatureProvider(source->dictionary(),

CreateFeature<APIFeature>));

} else if (name == "manifest") {

- provider.reset(new BaseFeatureProvider(source->dictionary(),

+ provider.reset(new JSONFeatureProvider(source->dictionary(),

CreateFeature<ManifestFeature>));

} else if (name == "permission") {

- provider.reset(new BaseFeatureProvider(source->dictionary(),

+ provider.reset(new JSONFeatureProvider(source->dictionary(),

CreateFeature<PermissionFeature>));

} else if (name == "behavior") {

- provider.reset(new BaseFeatureProvider(source->dictionary(),

+ provider.reset(new JSONFeatureProvider(source->dictionary(),

CreateFeature<BehaviorFeature>));

} else {

NOTREACHED();