[Extensions] Break up BaseFeatureProvider, create JSONFeatureProvider

extensions/test/test_extensions_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/test/test_extensions_client.h"
 
 #include "base/stl_util.h"
 #include "extensions/common/api/generated_schemas.h"
 #include "extensions/common/common_manifest_handlers.h"
 #include "extensions/common/extension_urls.h"
 #include "extensions/common/features/api_feature.h"
-#include "extensions/common/features/base_feature_provider.h"
 #include "extensions/common/features/behavior_feature.h"
 #include "extensions/common/features/feature_provider.h"
+#include "extensions/common/features/json_feature_provider.h"
 #include "extensions/common/features/json_feature_provider_source.h"
 #include "extensions/common/features/manifest_feature.h"
 #include "extensions/common/features/permission_feature.h"
 #include "extensions/common/manifest_handler.h"
 #include "extensions/common/permissions/extensions_api_permissions.h"
 #include "extensions/common/permissions/permissions_info.h"
 #include "extensions/common/url_pattern_set.h"
 #include "extensions/test/test_permission_message_provider.h"
 #include "grit/extensions_resources.h"
 
@@ skipping 46 matching lines @@
 const std::string TestExtensionsClient::GetProductName() {
   return "extensions_test";
 }
 
 std::unique_ptr<FeatureProvider> TestExtensionsClient::CreateFeatureProvider(
     const std::string& name) const {
   std::unique_ptr<FeatureProvider> provider;
   std::unique_ptr<JSONFeatureProviderSource> source(
       CreateFeatureProviderSource(name));
   if (name == "api") {
-    provider.reset(new BaseFeatureProvider(source->dictionary(),
+    provider.reset(new JSONFeatureProvider(source->dictionary(),
                                            CreateFeature<APIFeature>));
   } else if (name == "manifest") {
-    provider.reset(new BaseFeatureProvider(source->dictionary(),
+    provider.reset(new JSONFeatureProvider(source->dictionary(),
                                            CreateFeature<ManifestFeature>));
   } else if (name == "permission") {
-    provider.reset(new BaseFeatureProvider(source->dictionary(),
+    provider.reset(new JSONFeatureProvider(source->dictionary(),
                                            CreateFeature<PermissionFeature>));
   } else if (name == "behavior") {
-    provider.reset(new BaseFeatureProvider(source->dictionary(),
+    provider.reset(new JSONFeatureProvider(source->dictionary(),
                                            CreateFeature<BehaviorFeature>));
   } else {
     NOTREACHED();
   }
   return provider;
 }
 
 std::unique_ptr<JSONFeatureProviderSource>
 TestExtensionsClient::CreateFeatureProviderSource(
     const std::string& name) const {
@@ skipping 77 matching lines @@
 std::set<base::FilePath> TestExtensionsClient::GetBrowserImagePaths(
     const Extension* extension) {
   std::set<base::FilePath> result =
       ExtensionsClient::GetBrowserImagePaths(extension);
   for (auto* filter : browser_image_filters_)
     filter->Filter(extension, &result);
   return result;
 }
 
 }  // namespace extensions