[Extensions] Break up BaseFeatureProvider, create JSONFeatureProvider

extensions/shell/common/shell_extensions_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/shell/common/shell_extensions_client.h"
 
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/macros.h"
 #include "extensions/common/api/generated_schemas.h"
 #include "extensions/common/common_manifest_handlers.h"
 #include "extensions/common/extension_urls.h"
 #include "extensions/common/features/api_feature.h"
-#include "extensions/common/features/base_feature_provider.h"
 #include "extensions/common/features/behavior_feature.h"
+#include "extensions/common/features/json_feature_provider.h"
 #include "extensions/common/features/json_feature_provider_source.h"
 #include "extensions/common/features/manifest_feature.h"
 #include "extensions/common/features/permission_feature.h"
 #include "extensions/common/features/simple_feature.h"
 #include "extensions/common/manifest_handler.h"
 #include "extensions/common/permissions/permission_message_provider.h"
 #include "extensions/common/permissions/permissions_info.h"
 #include "extensions/common/permissions/permissions_provider.h"
 #include "extensions/common/url_pattern_set.h"
 #include "extensions/shell/common/api/generated_schemas.h"
@@ skipping 69 matching lines @@
 const std::string ShellExtensionsClient::GetProductName() {
   return "app_shell";
 }
 
 std::unique_ptr<FeatureProvider> ShellExtensionsClient::CreateFeatureProvider(
     const std::string& name) const {
   std::unique_ptr<FeatureProvider> provider;
   std::unique_ptr<JSONFeatureProviderSource> source(
       CreateFeatureProviderSource(name));
   if (name == "api") {
-    provider.reset(new BaseFeatureProvider(source->dictionary(),
+    provider.reset(new JSONFeatureProvider(source->dictionary(),
                                            CreateFeature<APIFeature>));
   } else if (name == "manifest") {
-    provider.reset(new BaseFeatureProvider(source->dictionary(),
+    provider.reset(new JSONFeatureProvider(source->dictionary(),
                                            CreateFeature<ManifestFeature>));
   } else if (name == "permission") {
-    provider.reset(new BaseFeatureProvider(source->dictionary(),
+    provider.reset(new JSONFeatureProvider(source->dictionary(),
                                            CreateFeature<PermissionFeature>));
   } else if (name == "behavior") {
-    provider.reset(new BaseFeatureProvider(source->dictionary(),
+    provider.reset(new JSONFeatureProvider(source->dictionary(),
                                            CreateFeature<BehaviorFeature>));
   } else {
     NOTREACHED();
   }
   return provider;
 }
 
 std::unique_ptr<JSONFeatureProviderSource>
 ShellExtensionsClient::CreateFeatureProviderSource(
     const std::string& name) const {
@@ skipping 81 matching lines @@
   return extension_urls::kChromeWebstoreUpdateURL;
 }
 
 bool ShellExtensionsClient::IsBlacklistUpdateURL(const GURL& url) const {
   // TODO(rockot): Maybe we want to do something else here. For now we accept
   // any URL as a blacklist URL because we don't really care.
   return true;
 }
 
 }  // namespace extensions