Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2132933003: VM: Remove collection of unused range feedback. (Closed)

Created:
4 years, 5 months ago by Florian Schneider
Modified:
4 years, 5 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Remove collection of unused range feedback. We can always put it back if the optimizer makes use of it. It's a lot of extra code that is unused. Therefore, remove it for now. BUG= R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/ab4490e5bffe340206694206e3342281eda650e3

Patch Set 1 #

Patch Set 2 : remove comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -1035 lines) Patch
M runtime/vm/assembler_arm.h View 1 chunk +0 lines, -12 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M runtime/vm/assembler_arm64.h View 1 chunk +0 lines, -12 lines 0 comments Download
M runtime/vm/assembler_arm64.cc View 1 chunk +0 lines, -45 lines 0 comments Download
M runtime/vm/assembler_arm64_test.cc View 1 chunk +0 lines, -62 lines 0 comments Download
M runtime/vm/assembler_arm_test.cc View 1 chunk +0 lines, -52 lines 0 comments Download
M runtime/vm/assembler_ia32.h View 2 chunks +0 lines, -15 lines 0 comments Download
M runtime/vm/assembler_ia32.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M runtime/vm/assembler_ia32_test.cc View 1 chunk +0 lines, -52 lines 0 comments Download
M runtime/vm/assembler_mips.h View 1 chunk +0 lines, -10 lines 0 comments Download
M runtime/vm/assembler_mips.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M runtime/vm/assembler_mips_test.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M runtime/vm/assembler_x64.h View 1 chunk +0 lines, -8 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M runtime/vm/assembler_x64_test.cc View 1 chunk +0 lines, -49 lines 0 comments Download
M runtime/vm/il_printer.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M runtime/vm/object.h View 4 chunks +1 line, -81 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +0 lines, -89 lines 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/stub_code.h View 2 chunks +0 lines, -6 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 1 11 chunks +13 lines, -57 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 1 11 chunks +16 lines, -68 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 1 14 chunks +10 lines, -54 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 1 9 chunks +13 lines, -61 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 1 16 chunks +16 lines, -72 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
4 years, 5 months ago (2016-07-08 20:07:00 UTC) #2
Vyacheslav Egorov (Google)
lgtm
4 years, 5 months ago (2016-07-11 12:00:32 UTC) #3
Florian Schneider
4 years, 5 months ago (2016-07-11 13:46:56 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
ab4490e5bffe340206694206e3342281eda650e3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698