Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: runtime/vm/assembler_arm.cc

Issue 2132933003: VM: Remove collection of unused range feedback. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: remove comment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_arm.h ('k') | runtime/vm/assembler_arm64.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_arm.cc
diff --git a/runtime/vm/assembler_arm.cc b/runtime/vm/assembler_arm.cc
index 2e39e2261047ec2a0f0b45b3aa480c595ae39a46..bca44b7dde3b54af4d91bbb31878a0d563fc9e9b 100644
--- a/runtime/vm/assembler_arm.cc
+++ b/runtime/vm/assembler_arm.cc
@@ -1921,47 +1921,6 @@ void Assembler::LoadTaggedClassIdMayBeSmi(Register result, Register object) {
}
-void Assembler::ComputeRange(Register result,
- Register value,
- Register scratch,
- Label* not_mint) {
- const Register hi = TMP;
- const Register lo = scratch;
-
- Label done;
- mov(result, Operand(value, LSR, kBitsPerWord - 1));
- tst(value, Operand(kSmiTagMask));
- b(&done, EQ);
- CompareClassId(value, kMintCid, result);
- b(not_mint, NE);
- ldr(hi, FieldAddress(value, Mint::value_offset() + kWordSize));
- ldr(lo, FieldAddress(value, Mint::value_offset()));
- rsb(result, hi, Operand(ICData::kInt32RangeBit));
- cmp(hi, Operand(lo, ASR, kBitsPerWord - 1));
- b(&done, EQ);
- LoadImmediate(result, ICData::kUint32RangeBit); // Uint32
- tst(hi, Operand(hi));
- LoadImmediate(result, ICData::kInt64RangeBit, NE); // Int64
- Bind(&done);
-}
-
-
-void Assembler::UpdateRangeFeedback(Register value,
- intptr_t index,
- Register ic_data,
- Register scratch1,
- Register scratch2,
- Label* miss) {
- ASSERT(ICData::IsValidRangeFeedbackIndex(index));
- ComputeRange(scratch1, value, scratch2, miss);
- ldr(scratch2, FieldAddress(ic_data, ICData::state_bits_offset()));
- orr(scratch2,
- scratch2,
- Operand(scratch1, LSL, ICData::RangeFeedbackShift(index)));
- str(scratch2, FieldAddress(ic_data, ICData::state_bits_offset()));
-}
-
-
static bool CanEncodeBranchOffset(int32_t offset) {
ASSERT(Utils::IsAligned(offset, 4));
return Utils::IsInt(Utils::CountOneBits(kBranchOffsetMask), offset);
« no previous file with comments | « runtime/vm/assembler_arm.h ('k') | runtime/vm/assembler_arm64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698