Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: runtime/vm/assembler_ia32.cc

Issue 2132933003: VM: Remove collection of unused range feedback. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: remove comment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_ia32.h ('k') | runtime/vm/assembler_ia32_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_ia32.cc
diff --git a/runtime/vm/assembler_ia32.cc b/runtime/vm/assembler_ia32.cc
index 1bc37d8f758c220f71e2d773fcaaa102b94a2e29..c6383148cc2e288a8e87c4f6a792984571a93028 100644
--- a/runtime/vm/assembler_ia32.cc
+++ b/runtime/vm/assembler_ia32.cc
@@ -2939,47 +2939,6 @@ void Assembler::LoadTaggedClassIdMayBeSmi(Register result, Register object) {
}
-void Assembler::ComputeRange(Register result,
- Register value,
- Register lo_temp,
- Register hi_temp,
- Label* not_mint) {
- Label done;
- movl(result, value);
- shrl(result, Immediate(kBitsPerWord - 1)); // Sign bit.
- testl(value, Immediate(kSmiTagMask));
- j(ZERO, &done, Assembler::kNearJump);
- CompareClassId(value, kMintCid, result);
- j(NOT_EQUAL, not_mint);
- movl(lo_temp, FieldAddress(value, Mint::value_offset()));
- movl(hi_temp, FieldAddress(value, Mint::value_offset() + kWordSize));
- movl(result, Immediate(ICData::kInt32RangeBit));
- subl(result, hi_temp); // 10 (positive int32), 11 (negative int32)
- sarl(lo_temp, Immediate(kBitsPerWord - 1));
- cmpl(lo_temp, hi_temp);
- j(EQUAL, &done, Assembler::kNearJump);
- movl(result, Immediate(ICData::kUint32RangeBit)); // Uint32
- cmpl(hi_temp, Immediate(0));
- j(EQUAL, &done, Assembler::kNearJump);
- movl(result, Immediate(ICData::kInt64RangeBit)); // Int64
- Bind(&done);
-}
-
-
-void Assembler::UpdateRangeFeedback(Register value,
- intptr_t index,
- Register ic_data,
- Register scratch1,
- Register scratch2,
- Register scratch3,
- Label* miss) {
- ASSERT(ICData::IsValidRangeFeedbackIndex(index));
- ComputeRange(scratch1, value, scratch2, scratch3, miss);
- shll(scratch1, Immediate(ICData::RangeFeedbackShift(index)));
- orl(FieldAddress(ic_data, ICData::state_bits_offset()), scratch1);
-}
-
-
Address Assembler::ElementAddressForIntIndex(bool is_external,
intptr_t cid,
intptr_t index_scale,
« no previous file with comments | « runtime/vm/assembler_ia32.h ('k') | runtime/vm/assembler_ia32_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698