Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1970)

Unified Diff: runtime/vm/assembler_arm64.cc

Issue 2132933003: VM: Remove collection of unused range feedback. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: remove comment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_arm64.h ('k') | runtime/vm/assembler_arm64_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_arm64.cc
diff --git a/runtime/vm/assembler_arm64.cc b/runtime/vm/assembler_arm64.cc
index 26c0b4ab67fb759692deceadf71c2c38fb43b219..004ae2148191ee5a0be867214001958d4ceff888 100644
--- a/runtime/vm/assembler_arm64.cc
+++ b/runtime/vm/assembler_arm64.cc
@@ -1036,51 +1036,6 @@ void Assembler::LoadTaggedClassIdMayBeSmi(Register result, Register object) {
}
-void Assembler::ComputeRange(Register result,
- Register value,
- Register scratch,
- Label* not_mint) {
- Label done, not_smi;
- tsti(value, Immediate(kSmiTagMask));
- b(&not_smi, NE);
-
- AsrImmediate(scratch, value, 32);
- LoadImmediate(result, ICData::kUint32RangeBit);
- cmp(scratch, Operand(1));
- b(&done, EQ);
-
- neg(scratch, scratch);
- add(result, scratch, Operand(ICData::kInt32RangeBit));
- cmp(scratch, Operand(1));
- LoadImmediate(TMP, ICData::kSignedRangeBit);
- csel(result, result, TMP, LS);
- b(&done);
-
- Bind(&not_smi);
- CompareClassId(value, kMintCid);
- b(not_mint, NE);
-
- LoadImmediate(result, ICData::kInt64RangeBit);
- Bind(&done);
-}
-
-
-void Assembler::UpdateRangeFeedback(Register value,
- intptr_t index,
- Register ic_data,
- Register scratch1,
- Register scratch2,
- Label* miss) {
- ASSERT(ICData::IsValidRangeFeedbackIndex(index));
- ComputeRange(scratch1, value, scratch2, miss);
- ldr(scratch2, FieldAddress(ic_data, ICData::state_bits_offset()), kWord);
- orrw(scratch2,
- scratch2,
- Operand(scratch1, LSL, ICData::RangeFeedbackShift(index)));
- str(scratch2, FieldAddress(ic_data, ICData::state_bits_offset()), kWord);
-}
-
-
// Frame entry and exit.
void Assembler::ReserveAlignedFrameSpace(intptr_t frame_space) {
// Reserve space for arguments and align frame before entering
« no previous file with comments | « runtime/vm/assembler_arm64.h ('k') | runtime/vm/assembler_arm64_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698