Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: runtime/vm/assembler_x64.cc

Issue 2132933003: VM: Remove collection of unused range feedback. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: remove comment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_x64.h ('k') | runtime/vm/assembler_x64_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_x64.cc
diff --git a/runtime/vm/assembler_x64.cc b/runtime/vm/assembler_x64.cc
index c266bf68191440fe624126e21de442905a8b858b..7c6ed4663791fc2664748043efdfb6680d68b8d2 100644
--- a/runtime/vm/assembler_x64.cc
+++ b/runtime/vm/assembler_x64.cc
@@ -3673,48 +3673,6 @@ void Assembler::LoadTaggedClassIdMayBeSmi(Register result, Register object) {
}
-void Assembler::ComputeRange(Register result, Register value, Label* not_mint) {
- Label done, not_smi;
- testl(value, Immediate(kSmiTagMask));
- j(NOT_ZERO, &not_smi, Assembler::kNearJump);
-
- sarq(value, Immediate(32)); // Take the tag into account.
- movq(result, Immediate(ICData::kUint32RangeBit)); // Uint32
- cmpq(value, Immediate(1));
- j(EQUAL, &done, Assembler::kNearJump);
-
- movq(result, Immediate(ICData::kInt32RangeBit));
- subq(result, value); // 10 (positive int32), 11 (negative int32)
- negq(value);
- cmpq(value, Immediate(1));
- j(BELOW_EQUAL, &done);
-
- // On 64-bit we don't need to track sign of smis outside of the Int32 range.
- // Just pretend they are all signed.
- movq(result, Immediate(ICData::kSignedRangeBit));
- jmp(&done);
-
- Bind(&not_smi);
- CompareClassId(value, kMintCid);
- j(NOT_EQUAL, not_mint);
- movq(result, Immediate(ICData::kInt64RangeBit));
-
- Bind(&done);
-}
-
-
-void Assembler::UpdateRangeFeedback(Register value,
- intptr_t index,
- Register ic_data,
- Register scratch,
- Label* miss) {
- ASSERT(ICData::IsValidRangeFeedbackIndex(index));
- ComputeRange(scratch, value, miss);
- shll(scratch, Immediate(ICData::RangeFeedbackShift(index)));
- orl(FieldAddress(ic_data, ICData::state_bits_offset()), scratch);
-}
-
-
Address Assembler::ElementAddressForIntIndex(bool is_external,
intptr_t cid,
intptr_t index_scale,
« no previous file with comments | « runtime/vm/assembler_x64.h ('k') | runtime/vm/assembler_x64_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698