ui: Refactor GLImageEGL for usage by targets other than EGL_NATIVE_BUFFER_ANDROID.

ui: Refactor GLImageEGL for usage by targets other than EGL_NATIVE_BUFFER_ANDROID.

No changes in behavior except a DCHECK will fail in BindTexImage
instead of returning false when egl_image_ is EGL_NO_IMAGE_KHR.
This is more appropritate as only a bug in the implementation of
GLImageEGL can cause this to happen.

BUG=356871
TBR=sky

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260194

[reveman, 2014-03-27 18:14:00]

This allows us to implement other EGLImage based GLImage types such as the Linux
dma-buf implemented by this patch:
https://codereview.chromium.org/215143002/

[reveman, 2014-03-27 18:15:20]

+kalyank

[reveman, 2014-03-27 22:52:04]

+boliu
+piman

Please take a look.

https://codereview.chromium.org/212933009/diff/40001/ui/gl/gl_image_android_n...
File ui/gl/gl_image_android_native_buffer.cc (left):

https://codereview.chromium.org/212933009/diff/40001/ui/gl/gl_image_android_n...
ui/gl/gl_image_android_native_buffer.cc:123: EGLint attrs[] =
{EGL_GL_TEXTURE_LEVEL_KHR, 0, EGL_IMAGE_PRESERVED_KHR,
Removing "EGL_GL_TEXTURE_LEVEL_KHR, 0" as that's default according to the spec.

https://codereview.chromium.org/212933009/diff/40001/ui/gl/gl_image_shm.cc
File ui/gl/gl_image_shm.cc (left):

https://codereview.chromium.org/212933009/diff/40001/ui/gl/gl_image_shm.cc#ol...
ui/gl/gl_image_shm.cc:165: EGLint attrs[] = {EGL_GL_TEXTURE_LEVEL_KHR, 0,
EGL_IMAGE_PRESERVED_KHR,
Removing "EGL_GL_TEXTURE_LEVEL_KHR, 0" here as well for consistency.

[piman, 2014-03-27 23:25:39]

lgtm

[reveman, 2014-03-27 23:34:16]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2014-03-27 23:37:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reveman@chromium.org/212933009/40001

[boliu, 2014-03-27 23:46:24]

lgtm

[commit-bot: I haz the power, 2014-03-28 00:02:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-28 00:02:44]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[reveman, 2014-03-28 00:08:09]

+sky for ui/gfx

[reveman, 2014-03-28 00:08:23]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2014-03-28 00:09:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reveman@chromium.org/212933009/40001

[commit-bot: I haz the power, 2014-03-28 02:31:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-28 02:31:42]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[fjhenigman, 2014-03-28 02:41:40]

The CQ bit was checked by fjhenigman@chromium.org

[commit-bot: I haz the power, 2014-03-28 02:43:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reveman@chromium.org/212933009/40001

[commit-bot: I haz the power, 2014-03-28 03:08:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-28 03:08:10]

Retried try job too often on ios_dbg_simulator for step(s) crypto_unittests,
url_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[fjhenigman, 2014-03-28 03:23:23]

The CQ bit was checked by fjhenigman@chromium.org

[commit-bot: I haz the power, 2014-03-28 03:23:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reveman@chromium.org/212933009/40001

[commit-bot: I haz the power, 2014-03-28 03:47:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-28 03:47:50]

Retried try job too often on ios_dbg_simulator for step(s) net_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[reveman, 2014-03-28 03:49:36]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2014-03-28 03:50:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reveman@chromium.org/212933009/40001

[fjhenigman, 2014-03-28 03:53:09]

The CQ bit was checked by fjhenigman@chromium.org

[commit-bot: I haz the power, 2014-03-28 07:54:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-28 07:55:00]

Retried try job too often on ios_dbg_simulator for step(s) base_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[reveman, 2014-03-28 13:35:03]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2014-03-28 13:35:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reveman@chromium.org/212933009/40001

[sky, 2014-03-28 15:55:31]

ui/gfx/gpu_memory_buffer.h LGTM

Also, can you update owners for gpu_memory_buffer. I clearly am not a good
reviewer for it.

[commit-bot: I haz the power, 2014-03-28 18:07:38]

Change committed as 260194