ui: Refactor GLImageEGL for usage by targets other than EGL_NATIVE_BUFFER_ANDROID.

ui/gl/gl_image_shm.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gl/gl_image_shm.h"
 
 #include "base/debug/trace_event.h"
 #include "base/process/process_handle.h"
 #include "ui/gl/scoped_binders.h"
 
@@ skipping 144 matching lines @@
                    0,  // mip level
                    TextureFormat(internalformat_),
                    size_.width(),
                    size_.height(),
                    0,  // border
                    DataFormat(internalformat_),
                    DataType(internalformat_),
                    shared_memory_->memory());
     }
 
-    EGLint attrs[] = {EGL_GL_TEXTURE_LEVEL_KHR, 0, EGL_IMAGE_PRESERVED_KHR,

[reveman, 2014/03/27 22:52:04]

Removing "EGL_GL_TEXTURE_LEVEL_KHR, 0" here as well for consistency.

-                      EGL_TRUE, EGL_NONE};
+    EGLint attrs[] = {EGL_IMAGE_PRESERVED_KHR, EGL_TRUE, EGL_NONE};
     // Need to pass current EGL rendering context to eglCreateImageKHR for
     // target type EGL_GL_TEXTURE_2D_KHR.
     egl_image_ =
         eglCreateImageKHR(GLSurfaceEGL::GetHardwareDisplay(),
                           eglGetCurrentContext(),
                           EGL_GL_TEXTURE_2D_KHR,
                           reinterpret_cast<EGLClientBuffer>(egl_texture_id_),
                           attrs);
     DCHECK_NE(EGL_NO_IMAGE_KHR, egl_image_)
         << "Error creating EGLImage: " << eglGetError();
@@ skipping 15 matching lines @@
                0,  // border
                DataFormat(internalformat_),
                DataType(internalformat_),
                shared_memory_->memory());
 
   shared_memory_->Unmap();
   return true;
 }
 
 }  // namespace gfx