Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 2122543002: Replace Closure in TaskRunner::PostTask with OneShotCallback (Closed)

Created:
4 years, 5 months ago by tzik
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, sievers+watch_chromium.org, fdoray+watch_chromium.org, tracing+reviews_chromium.org, kinuko+watch, ben+mojo_chromium.org, miu+watch_chromium.org, darin (slow to review), cbentzel+watch_chromium.org, robliao+watch_chromium.org, gab+watch_chromium.org, jam, abarth-chromium, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, xjz+watch_chromium.org, blink-worker-reviews_chromium.org, mlamouri+watch-content_chromium.org, chromoting-reviews_chromium.org, imcheng+watch_chromium.org, jasonroberts+watch_google.com, feature-media-reviews_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org, tfarina, avayvod+watch_chromium.org, Aaron Boodman, wfh+watch_chromium.org, cc-bugs_chromium.org, scheduler-bugs_chromium.org, isheriff+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@07_oneshot
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace Closure in TaskRunner::PostTask with OneShotClosure CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Patch Set 1 : rebase #

Patch Set 2 : fix #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1694 lines, -1156 lines) Patch
M base/bind.h View 2 chunks +2 lines, -5 lines 0 comments Download
M base/bind_unittest.cc View 1 2 16 chunks +458 lines, -239 lines 0 comments Download
M base/callback_forward.h View 2 chunks +0 lines, -3 lines 0 comments Download
M base/critical_closure.h View 1 2 chunks +24 lines, -24 lines 0 comments Download
M base/debug/task_annotator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/debug/task_annotator.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M base/debug/task_annotator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/deferred_sequenced_task_runner.h View 3 chunks +7 lines, -5 lines 0 comments Download
M base/deferred_sequenced_task_runner.cc View 4 chunks +22 lines, -18 lines 0 comments Download
M base/files/file_util_proxy.cc View 1 chunk +1 line, -2 lines 0 comments Download
M base/files/important_file_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M base/files/important_file_writer.cc View 2 chunks +3 lines, -5 lines 0 comments Download
A base/mac/libdispatch_task_runner.h View 1 1 chunk +80 lines, -0 lines 0 comments Download
A base/mac/libdispatch_task_runner.cc View 1 1 chunk +83 lines, -0 lines 0 comments Download
M base/message_loop/incoming_task_queue.h View 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop/incoming_task_queue.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M base/message_loop/message_loop.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/message_loop/message_loop.cc View 4 chunks +13 lines, -15 lines 0 comments Download
M base/message_loop/message_loop_task_runner.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/message_loop/message_loop_task_runner.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M base/message_loop/message_loop_task_runner_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M base/message_loop/message_pump_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/pending_task.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/pending_task.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M base/sequenced_task_runner.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/sequenced_task_runner.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M base/task_runner.h View 3 chunks +4 lines, -4 lines 0 comments Download
M base/task_runner.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M base/task_runner_util.h View 2 chunks +28 lines, -13 lines 0 comments Download
M base/task_scheduler/post_task.h View 3 chunks +6 lines, -6 lines 0 comments Download
M base/task_scheduler/post_task.cc View 3 chunks +16 lines, -12 lines 0 comments Download
M base/task_scheduler/scheduler_worker.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/task_scheduler/scheduler_worker_pool_impl.cc View 5 chunks +12 lines, -10 lines 0 comments Download
M base/task_scheduler/sequence.h View 1 chunk +1 line, -1 line 0 comments Download
M base/task_scheduler/sequence.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/task_scheduler/task.h View 1 chunk +1 line, -1 line 0 comments Download
M base/task_scheduler/task.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/task_scheduler/task_scheduler.h View 1 chunk +1 line, -1 line 0 comments Download
M base/task_scheduler/task_scheduler_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M base/task_scheduler/task_scheduler_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/task_scheduler/task_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
M base/task_scheduler/task_tracker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/test/null_task_runner.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/test/null_task_runner.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M base/test/test_mock_time_task_runner.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/test/test_mock_time_task_runner.cc View 5 chunks +17 lines, -12 lines 0 comments Download
M base/test/test_pending_task.h View 2 chunks +4 lines, -3 lines 0 comments Download
M base/test/test_pending_task.cc View 1 chunk +9 lines, -8 lines 0 comments Download
M base/test/test_simple_task_runner.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/test/test_simple_task_runner.cc View 2 chunks +10 lines, -10 lines 0 comments Download
M base/threading/post_task_and_reply_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M base/threading/post_task_and_reply_impl.cc View 5 chunks +12 lines, -12 lines 0 comments Download
M base/threading/post_task_and_reply_impl_unittest.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M base/threading/sequenced_worker_pool.h View 5 chunks +8 lines, -8 lines 0 comments Download
M base/threading/sequenced_worker_pool.cc View 21 chunks +62 lines, -55 lines 0 comments Download
M base/threading/worker_pool.h View 1 chunk +4 lines, -3 lines 0 comments Download
M base/threading/worker_pool.cc View 7 chunks +12 lines, -12 lines 0 comments Download
M base/threading/worker_pool_posix.h View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/worker_pool_posix.cc View 5 chunks +9 lines, -8 lines 0 comments Download
M base/threading/worker_pool_win.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M base/trace_event/memory_dump_manager_unittest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M cc/base/delayed_unique_notifier_unittest.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M cc/test/ordered_simple_task_runner.h View 4 chunks +7 lines, -5 lines 0 comments Download
M cc/test/ordered_simple_task_runner.cc View 4 chunks +27 lines, -17 lines 0 comments Download
M cc/test/ordered_simple_task_runner_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/after_startup_task_utils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/after_startup_task_utils.cc View 4 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/after_startup_task_utils_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/users/mock_user_manager.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/memory/tab_manager_unittest.cc View 7 chunks +8 lines, -16 lines 0 comments Download
M chromecast/base/system_time_change_notifier_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chromeos/dbus/blocking_method_caller_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/tpm/tpm_token_info_getter_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/memory_pressure/memory_pressure_monitor_unittest.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M components/timers/alarm_timer_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/user_manager/fake_user_manager.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/browser_thread_impl.h View 1 chunk +5 lines, -6 lines 0 comments Download
M content/browser/browser_thread_impl.cc View 5 chunks +36 lines, -34 lines 0 comments Download
M content/browser/compositor/reflector_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/dom_storage/dom_storage_task_runner.h View 3 chunks +6 lines, -6 lines 0 comments Download
M content/browser/dom_storage/dom_storage_task_runner.cc View 2 chunks +11 lines, -10 lines 0 comments Download
M content/browser/startup_task_runner_unittest.cc View 10 chunks +28 lines, -37 lines 0 comments Download
M content/child/worker_thread_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/browser_thread.h View 3 chunks +13 lines, -14 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/content_browser_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/categorized_worker_pool.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/categorized_worker_pool.cc View 5 chunks +9 lines, -10 lines 0 comments Download
M content/renderer/render_thread_impl_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/test_blink_web_unit_test_support.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M device/bluetooth/test/bluetooth_test_win.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M docs/callback.md View 11 chunks +251 lines, -135 lines 0 comments Download
M ios/web/public/web_thread.h View 1 2 chunks +10 lines, -10 lines 0 comments Download
M ios/web/web_thread_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_thread_impl.cc View 1 6 chunks +32 lines, -29 lines 0 comments Download
M media/base/fake_single_thread_task_runner.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/base/fake_single_thread_task_runner.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M media/cast/test/skewed_single_thread_task_runner.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/cast/test/skewed_single_thread_task_runner.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M mojo/public/cpp/bindings/tests/bind_task_runner_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M net/quic/test_tools/test_task_runner.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/test_task_runner.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M net/ssl/channel_id_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/base/auto_thread_task_runner.h View 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/base/auto_thread_task_runner.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M remoting/client/plugin/pepper_main_thread_task_runner.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/client/plugin/pepper_main_thread_task_runner.cc View 1 1 chunk +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.h View 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc View 10 chunks +24 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_delegate_for_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_delegate_for_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/compositor_worker_scheduler.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/idle_helper_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/scheduler_tqm_delegate_for_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/scheduler_tqm_delegate_for_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/scheduler_tqm_delegate_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/scheduler_tqm_delegate_impl.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/single_thread_idle_task_runner.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/web_task_runner_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/web_task_runner_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/idle_time_estimator_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/task_cost_estimator_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/test/fake_web_task_runner.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/test/fake_web_task_runner.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/test/lazy_scheduler_message_loop_delegate_for_tests.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/test/lazy_scheduler_message_loop_delegate_for_tests.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/test/renderer_scheduler_test_support.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/WebTaskRunner.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/platform/scheduler/child/single_thread_idle_task_runner.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/public/platform/scheduler/test/renderer_scheduler_test_support.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/accelerated_widget_mac/window_resize_helper_mac.cc View 1 6 chunks +11 lines, -11 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 59 (58 generated)
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 05:11:11 UTC) #18
Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.blink
   For more details, see http://crbug.com/617627.

Powered by Google App Engine
This is Rietveld 408576698