Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Side by Side Diff: base/task_runner.cc

Issue 2122543002: Replace Closure in TaskRunner::PostTask with OneShotCallback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@07_oneshot
Patch Set: fix Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/task_runner.h ('k') | base/task_runner_util.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/task_runner.h" 5 #include "base/task_runner.h"
6 6
7 #include "base/callback.h"
7 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
8 #include "base/logging.h" 9 #include "base/logging.h"
9 #include "base/threading/post_task_and_reply_impl.h" 10 #include "base/threading/post_task_and_reply_impl.h"
10 11
11 namespace base { 12 namespace base {
12 13
13 namespace { 14 namespace {
14 15
15 // TODO(akalin): There's only one other implementation of 16 // TODO(akalin): There's only one other implementation of
16 // PostTaskAndReplyImpl in WorkerPool. Investigate whether it'll be 17 // PostTaskAndReplyImpl in WorkerPool. Investigate whether it'll be
17 // possible to merge the two. 18 // possible to merge the two.
18 class PostTaskAndReplyTaskRunner : public internal::PostTaskAndReplyImpl { 19 class PostTaskAndReplyTaskRunner : public internal::PostTaskAndReplyImpl {
19 public: 20 public:
20 explicit PostTaskAndReplyTaskRunner(TaskRunner* destination); 21 explicit PostTaskAndReplyTaskRunner(TaskRunner* destination);
21 22
22 private: 23 private:
23 bool PostTask(const tracked_objects::Location& from_here, 24 bool PostTask(const tracked_objects::Location& from_here,
24 const Closure& task) override; 25 OnceClosure task) override;
25 26
26 // Non-owning. 27 // Non-owning.
27 TaskRunner* destination_; 28 TaskRunner* destination_;
28 }; 29 };
29 30
30 PostTaskAndReplyTaskRunner::PostTaskAndReplyTaskRunner( 31 PostTaskAndReplyTaskRunner::PostTaskAndReplyTaskRunner(
31 TaskRunner* destination) : destination_(destination) { 32 TaskRunner* destination) : destination_(destination) {
32 DCHECK(destination_); 33 DCHECK(destination_);
33 } 34 }
34 35
35 bool PostTaskAndReplyTaskRunner::PostTask( 36 bool PostTaskAndReplyTaskRunner::PostTask(
36 const tracked_objects::Location& from_here, 37 const tracked_objects::Location& from_here,
37 const Closure& task) { 38 OnceClosure task) {
38 return destination_->PostTask(from_here, task); 39 return destination_->PostTask(from_here, std::move(task));
39 } 40 }
40 41
41 } // namespace 42 } // namespace
42 43
43 bool TaskRunner::PostTask(const tracked_objects::Location& from_here, 44 bool TaskRunner::PostTask(const tracked_objects::Location& from_here,
44 const Closure& task) { 45 OnceClosure task) {
45 return PostDelayedTask(from_here, task, base::TimeDelta()); 46 return PostDelayedTask(from_here, std::move(task), base::TimeDelta());
46 } 47 }
47 48
48 bool TaskRunner::PostTaskAndReply( 49 bool TaskRunner::PostTaskAndReply(const tracked_objects::Location& from_here,
49 const tracked_objects::Location& from_here, 50 OnceClosure task,
50 const Closure& task, 51 OnceClosure reply) {
51 const Closure& reply) {
52 return PostTaskAndReplyTaskRunner(this).PostTaskAndReply( 52 return PostTaskAndReplyTaskRunner(this).PostTaskAndReply(
53 from_here, task, reply); 53 from_here, std::move(task), std::move(reply));
54 } 54 }
55 55
56 TaskRunner::TaskRunner() {} 56 TaskRunner::TaskRunner() {}
57 57
58 TaskRunner::~TaskRunner() {} 58 TaskRunner::~TaskRunner() {}
59 59
60 void TaskRunner::OnDestruct() const { 60 void TaskRunner::OnDestruct() const {
61 delete this; 61 delete this;
62 } 62 }
63 63
64 void TaskRunnerTraits::Destruct(const TaskRunner* task_runner) { 64 void TaskRunnerTraits::Destruct(const TaskRunner* task_runner) {
65 task_runner->OnDestruct(); 65 task_runner->OnDestruct();
66 } 66 }
67 67
68 } // namespace base 68 } // namespace base
OLDNEW
« no previous file with comments | « base/task_runner.h ('k') | base/task_runner_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698