Replace string::find(prefix) == 0 pattern with base::StartsWith().

Replace string::find(prefix) == 0 pattern with base::StartsWith().

base::StartsWith() should be O(|prefix|) whereas string::find() is
  pretty bad, O(|string| * |prefix|).

TBR=jam@chromium.org
BUG=None
Test=None, internal cleanup.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng

Committed: https://crrev.com/53bfbe932191085b5d69f824a9923bccc26d58dc
Cr-Commit-Position: refs/heads/master@{#404307}

[lazyboy, 2016-07-02 01:17:03]

Description was changed from

==========
Replace string::find(prefix) == 0 pattern with base::StartsWith().

base::StartsWith() should be O(|prefix|) whereas string::find() is
  pretty bad.

BUG=None
Test=None, internal cleanup.
==========

to

==========
Replace string::find(prefix) == 0 pattern with base::StartsWith().

base::StartsWith() should be O(|prefix|) whereas string::find() is
  pretty bad.

BUG=None
Test=None, internal cleanup.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

[lazyboy, 2016-07-07 21:55:36]

Description was changed from

==========
Replace string::find(prefix) == 0 pattern with base::StartsWith().

base::StartsWith() should be O(|prefix|) whereas string::find() is
  pretty bad.

BUG=None
Test=None, internal cleanup.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

to

==========
Replace string::find(prefix) == 0 pattern with base::StartsWith().

base::StartsWith() should be O(|prefix|) whereas string::find() is
  pretty bad, likely O(|string| * |prefix|).

BUG=None
Test=None, internal cleanup.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

[lazyboy, 2016-07-07 21:57:14]

Description was changed from

==========
Replace string::find(prefix) == 0 pattern with base::StartsWith().

base::StartsWith() should be O(|prefix|) whereas string::find() is
  pretty bad, likely O(|string| * |prefix|).

BUG=None
Test=None, internal cleanup.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

to

==========
Replace string::find(prefix) == 0 pattern with base::StartsWith().

base::StartsWith() should be O(|prefix|) whereas string::find() is
  pretty bad, O(|string| * |prefix|).

BUG=None
Test=None, internal cleanup.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

[lazyboy, 2016-07-07 22:01:15]

lazyboy@chromium.org changed reviewers:
+ thestig@chromium.org

[lazyboy, 2016-07-07 22:01:16]

thestig@ for kicking off the review, because you're a base OWNER and this CL is
mainly to use base::StartsWith().

This is not an exhaustive list of files, I code searched for:
find\(.*!=\ 0 case:yes lang:cc
find\(.*==\ 0 case:yes lang:cc
and changed the files.

[Lei Zhang, 2016-07-07 22:33:50]

lgtm

I looked at the whole CL, so TBR remaining reviewers?

https://codereview.chromium.org/2121513002/diff/20001/chrome/test/chromedrive...
File chrome/test/chromedriver/session_commands.cc (left):

https://codereview.chromium.org/2121513002/diff/20001/chrome/test/chromedrive...
chrome/test/chromedriver/session_commands.cc:68:
std::string(kWindowHandlePrefix).length());
At least this is test code?

https://codereview.chromium.org/2121513002/diff/20001/media/blink/resource_mu...
File media/blink/resource_multibuffer_data_provider.cc (right):

https://codereview.chromium.org/2121513002/diff/20001/media/blink/resource_mu...
media/blink/resource_multibuffer_data_provider.cc:465: const char
kUpThroughBytesUnit[] = "bytes ";
Thanks

[lazyboy, 2016-07-07 23:44:50]

I'll TBR rest of the OWNERs, thanks.

https://codereview.chromium.org/2121513002/diff/20001/chrome/test/chromedrive...
File chrome/test/chromedriver/session_commands.cc (left):

https://codereview.chromium.org/2121513002/diff/20001/chrome/test/chromedrive...
chrome/test/chromedriver/session_commands.cc:68:
std::string(kWindowHandlePrefix).length());
On 2016/07/07 22:33:49, Lei Zhang wrote:
> At least this is test code?

Reverted.

Done.

https://codereview.chromium.org/2121513002/diff/20001/media/blink/resource_mu...
File media/blink/resource_multibuffer_data_provider.cc (right):

https://codereview.chromium.org/2121513002/diff/20001/media/blink/resource_mu...
media/blink/resource_multibuffer_data_provider.cc:465: const char
kUpThroughBytesUnit[] = "bytes ";
On 2016/07/07 22:33:49, Lei Zhang wrote:
> Thanks

Acknowledged.

[Lei Zhang, 2016-07-07 23:50:08]

https://codereview.chromium.org/2121513002/diff/20001/chrome/test/chromedrive...
File chrome/test/chromedriver/session_commands.cc (left):

https://codereview.chromium.org/2121513002/diff/20001/chrome/test/chromedrive...
chrome/test/chromedriver/session_commands.cc:68:
std::string(kWindowHandlePrefix).length());
On 2016/07/07 23:44:50, lazyboy wrote:
> On 2016/07/07 22:33:49, Lei Zhang wrote:
> > At least this is test code?
> 
> Reverted.
> 
> Done.

No, no, I was fine with the change. I dislike the existing code, and I was
trying to say at least we don't ship it in production.

[lazyboy, 2016-07-07 23:56:05]

Patchset #3 (id:40001) has been deleted

[lazyboy, 2016-07-07 23:57:12]

https://codereview.chromium.org/2121513002/diff/20001/chrome/test/chromedrive...
File chrome/test/chromedriver/session_commands.cc (left):

https://codereview.chromium.org/2121513002/diff/20001/chrome/test/chromedrive...
chrome/test/chromedriver/session_commands.cc:68:
std::string(kWindowHandlePrefix).length());
On 2016/07/07 23:50:08, Lei Zhang wrote:
> On 2016/07/07 23:44:50, lazyboy wrote:
> > On 2016/07/07 22:33:49, Lei Zhang wrote:
> > > At least this is test code?
> > 
> > Reverted.
> > 
> > Done.
> 
> No, no, I was fine with the change. I dislike the existing code, and I was
> trying to say at least we don't ship it in production.

Ah, deleted patchset #3

[Lei Zhang, 2016-07-08 00:06:12]

On 2016/07/07 23:57:12, lazyboy wrote:
> Ah, deleted patchset #3

looks good, as before.

[lazyboy, 2016-07-08 00:09:34]

Description was changed from

==========
Replace string::find(prefix) == 0 pattern with base::StartsWith().

base::StartsWith() should be O(|prefix|) whereas string::find() is
  pretty bad, O(|string| * |prefix|).

BUG=None
Test=None, internal cleanup.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

to

==========
Replace string::find(prefix) == 0 pattern with base::StartsWith().

base::StartsWith() should be O(|prefix|) whereas string::find() is
  pretty bad, O(|string| * |prefix|).

TBR=jam@chromium.org
BUG=None
Test=None, internal cleanup.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

[lazyboy, 2016-07-08 00:14:54]

The CQ bit was checked by lazyboy@chromium.org

[commit-bot: I haz the power, 2016-07-08 00:15:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 02:04:21]

Description was changed from

==========
Replace string::find(prefix) == 0 pattern with base::StartsWith().

base::StartsWith() should be O(|prefix|) whereas string::find() is
  pretty bad, O(|string| * |prefix|).

TBR=jam@chromium.org
BUG=None
Test=None, internal cleanup.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

to

==========
Replace string::find(prefix) == 0 pattern with base::StartsWith().

base::StartsWith() should be O(|prefix|) whereas string::find() is
  pretty bad, O(|string| * |prefix|).

TBR=jam@chromium.org
BUG=None
Test=None, internal cleanup.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

[commit-bot: I haz the power, 2016-07-08 02:04:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-08 02:04:35]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-08 02:09:43]

Description was changed from

==========
Replace string::find(prefix) == 0 pattern with base::StartsWith().

base::StartsWith() should be O(|prefix|) whereas string::find() is
  pretty bad, O(|string| * |prefix|).

TBR=jam@chromium.org
BUG=None
Test=None, internal cleanup.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

to

==========
Replace string::find(prefix) == 0 pattern with base::StartsWith().

base::StartsWith() should be O(|prefix|) whereas string::find() is
  pretty bad, O(|string| * |prefix|).

TBR=jam@chromium.org
BUG=None
Test=None, internal cleanup.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win10_chromium_x64_rel_ng

Committed: https://crrev.com/53bfbe932191085b5d69f824a9923bccc26d58dc
Cr-Commit-Position: refs/heads/master@{#404307}
==========

[commit-bot: I haz the power, 2016-07-08 02:09:44]

Patchset 2 (id:??) landed as
https://crrev.com/53bfbe932191085b5d69f824a9923bccc26d58dc
Cr-Commit-Position: refs/heads/master@{#404307}

[markusheintz_, 2016-07-08 13:02:00]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2137503002/ by markusheintz@chromium.org.

The reason for reverting is: Bisect believes that this CL caused the Win builder
to break. 

https://build.chromium.org/p/chromium/builders/Win%20x64/builds/2267
https://build.chromium.org/p/chromium/builders/Win/builds/45048

For context see:
https://bugs.chromium.org/p/chromium/issues/detail?id=626539.

[markusheintz_, 2016-07-08 13:02:04]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2131933002/ by markusheintz@chromium.org.

The reason for reverting is: Bisect believes that this CL caused the Win builder
to break. 

https://build.chromium.org/p/chromium/builders/Win%20x64/builds/2267
https://build.chromium.org/p/chromium/builders/Win/builds/45048

For context see:
https://bugs.chromium.org/p/chromium/issues/detail?id=626539.

[Primiano Tucci (use gerrit), 2016-07-08 13:16:14]

On 2016/07/08 13:02:04, markusheintz_ wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/2131933002/ by
mailto:markusheintz@chromium.org.
> 
> The reason for reverting is: Bisect believes that this CL caused the Win
builder
> to break. 
> 
> https://build.chromium.org/p/chromium/builders/Win%20x64/builds/2267
> https://build.chromium.org/p/chromium/builders/Win/builds/45048
> 
> For context see:
> https://bugs.chromium.org/p/chromium/issues/detail?id=626539.

Turns out we just need a very limited revert
https://codereview.chromium.org/2135653002/

[markusheintz_, 2016-07-08 14:19:49]

On 2016/07/08 13:16:14, Primiano Tucci wrote:
> On 2016/07/08 13:02:04, markusheintz_ wrote:
> > A revert of this CL (patchset #2 id:20001) has been created in
> > https://codereview.chromium.org/2131933002/ by
> mailto:markusheintz@chromium.org.
> > 
> > The reason for reverting is: Bisect believes that this CL caused the Win
> builder
> > to break. 
> > 
> > https://build.chromium.org/p/chromium/builders/Win%20x64/builds/2267
> > https://build.chromium.org/p/chromium/builders/Win/builds/45048
> > 
> > For context see:
> > https://bugs.chromium.org/p/chromium/issues/detail?id=626539.
> 
> Turns out we just need a very limited revert
> https://codereview.chromium.org/2135653002/

FYI the revert was reverted (https://codereview.chromium.org/2136453004/)