components/sync_sessions/favicon_cache_unittest.cc - Issue 2121513002: Replace string::find(prefix) == 0 pattern with base::StartsWith().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_sessions/favicon_cache_unittest.cc

Issue 2121513002: Replace string::find(prefix) == 0 pattern with base::StartsWith(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix typos Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/chromedriver/session_commands.cc ('K') | « components/os_crypt/os_crypt_posix.cc ('k') | content/browser/dom_storage/session_storage_database.cc » ('j') | media/blink/resource_multibuffer_data_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync_sessions/favicon_cache_unittest.cc

diff --git a/components/sync_sessions/favicon_cache_unittest.cc b/components/sync_sessions/favicon_cache_unittest.cc

index 0eb20923ed9af5384fed9c0151b2a265ca040187..b2aac8caee18530076b8c01c369096274bda8e5a 100644

--- a/components/sync_sessions/favicon_cache_unittest.cc

+++ b/components/sync_sessions/favicon_cache_unittest.cc

@@ -11,6 +11,7 @@

#include "base/memory/ptr_util.h"

#include "base/message_loop/message_loop.h"

#include "base/strings/string_number_conversions.h"

+#include "base/strings/string_util.h"

#include "base/strings/stringprintf.h"

#include "base/time/time.h"

#include "sync/api/attachments/attachment_id.h"

@@ -244,7 +245,7 @@ int GetFaviconId(const syncer::SyncChange change) {

std::string tag = syncer::SyncDataLocal(change.sync_data()).GetTag();

const std::string kPrefix = "http://bla.com/";

const std::string kSuffix = ".ico";

- if (tag.find(kPrefix) != 0)

+ if (!base::StartsWith(tag, kPrefix, base::CompareCase::SENSITIVE))

return -1;

std::string temp = tag.substr(kPrefix.length());

if (temp.rfind(kSuffix) <= 0)