chrome/browser/extensions/api/cookies/cookies_helpers.cc - Issue 2121513002: Replace string::find(prefix) == 0 pattern with base::StartsWith().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/cookies/cookies_helpers.cc

Issue 2121513002: Replace string::find(prefix) == 0 pattern with base::StartsWith(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix typos Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/download_browsertest.cc ('k') | chrome/browser/profiles/profile_avatar_icon_util.cc » ('j') | chrome/test/chromedriver/session_commands.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/cookies/cookies_helpers.cc

diff --git a/chrome/browser/extensions/api/cookies/cookies_helpers.cc b/chrome/browser/extensions/api/cookies/cookies_helpers.cc

index 0ca4569488167234e3bc2f3384aa76fddbcc91af..b5073942cf1c2466f2300b95532c1f88bd419836 100644

--- a/chrome/browser/extensions/api/cookies/cookies_helpers.cc

+++ b/chrome/browser/extensions/api/cookies/cookies_helpers.cc

@@ -134,7 +134,9 @@ GURL GetURLFromCanonicalCookie(const net::CanonicalCookie& cookie) {

const std::string scheme =

cookie.IsSecure() ? url::kHttpsScheme : url::kHttpScheme;

const std::string host =

- domain_key.find('.') != 0 ? domain_key : domain_key.substr(1);

+ base::StartsWith(domain_key, ".", base::CompareCase::SENSITIVE)

+ ? domain_key.substr(1)

+ : domain_key;

return GURL(scheme + url::kStandardSchemeSeparator + host + "/");

}