content/browser/webui/shared_resources_data_source.cc - Issue 2121513002: Replace string::find(prefix) == 0 pattern with base::StartsWith().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/webui/shared_resources_data_source.cc

Issue 2121513002: Replace string::find(prefix) == 0 pattern with base::StartsWith(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix typos Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/chromedriver/session_commands.cc ('K') | « content/browser/iframe_zoom_browsertest.cc ('k') | media/blink/buffered_resource_loader.cc » ('j') | media/blink/resource_multibuffer_data_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/webui/shared_resources_data_source.cc

diff --git a/content/browser/webui/shared_resources_data_source.cc b/content/browser/webui/shared_resources_data_source.cc

index 7e5baf3337e384dbfac72140d9cfdeb299e0679c..d71556958be6acc1b88b665f23c4160f077e1e48 100644

--- a/content/browser/webui/shared_resources_data_source.cc

+++ b/content/browser/webui/shared_resources_data_source.cc

@@ -160,8 +160,10 @@ SharedResourcesDataSource::GetAccessControlAllowOriginForOrigin(

// back.

std::string allowed_origin_prefix = kChromeUIScheme;

allowed_origin_prefix += "://";

- if (origin.find(allowed_origin_prefix) != 0)

+ if (!base::StartsWith(origin, allowed_origin_prefix,

+ base::CompareCase::SENSITIVE)) {

return "null";

+ }

return origin;

}