chrome/browser/ui/find_bar/find_bar_controller.cc - Issue 2121513002: Replace string::find(prefix) == 0 pattern with base::StartsWith().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/find_bar/find_bar_controller.cc

Issue 2121513002: Replace string::find(prefix) == 0 pattern with base::StartsWith(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix typos Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/browser_navigator_browsertest.cc ('k') | chrome/test/chromedriver/net/adb_client_socket.cc » ('j') | chrome/test/chromedriver/session_commands.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/find_bar/find_bar_controller.cc

diff --git a/chrome/browser/ui/find_bar/find_bar_controller.cc b/chrome/browser/ui/find_bar/find_bar_controller.cc

index 909749f2437a3f06cc3c1bfaafb13c7f9ef92713..f30cf920bc94356e5d95cbec12a3ae878cd53c22 100644

--- a/chrome/browser/ui/find_bar/find_bar_controller.cc

+++ b/chrome/browser/ui/find_bar/find_bar_controller.cc

@@ -8,6 +8,7 @@

#include "base/i18n/rtl.h"

#include "base/logging.h"

+#include "base/strings/string_util.h"

#include "build/build_config.h"

#include "chrome/browser/chrome_notification_types.h"

#include "chrome/browser/profiles/profile.h"

@@ -143,8 +144,10 @@ void FindBarController::Observe(int type,

const base::string16& last_search =

find_tab_helper->previous_find_text();

const base::string16& current_search = find_tab_helper->find_text();

- if (last_search.find(current_search) != 0)

+ if (base::StartsWith(last_search, current_search,

+ base::CompareCase::SENSITIVE)) {

find_bar_->AudibleAlert();

+ }

}

} else if (type == content::NOTIFICATION_NAV_ENTRY_COMMITTED) {