Detemplatize cc property nodes

Detemplatize cc property nodes

Property nodes used to be instantiation of TreeNode<T> template with different
payload. There is little gain from it (deduplicate 500 bytes of code for 3
times), while made us to type "->data." a few hundred times.
Also this extra level of indirection adds invisible mental overheads.

This CL detemplatizes TreeNode<T> and flatten the payload to the node.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/dba8b150955e55508ca018ab721c14dba1374fd3
Cr-Commit-Position: refs/heads/master@{#404339}

[trchen, 2016-07-01 22:35:35]

Description was changed from

==========
Detemplatize cc property nodes

Property nodes used to be instantiation of TreeNode<T> template with different
payload. There is little gain from it (deduplicate 500 bytes of code for 3
times), while made us to type "->data." fore nearly a thousand times. Also
the extra level of indirection adds invisible mental overheads.

This CL detemplatizes TreeNode<T> and flatten the payload to the node.
==========

to

==========
Detemplatize cc property nodes

Property nodes used to be instantiation of TreeNode<T> template with different
payload. There is little gain from it (deduplicate 500 bytes of code for 3
times), while made us to type "->data." fore nearly a thousand times. Also
the extra level of indirection adds invisible mental overheads.

This CL detemplatizes TreeNode<T> and flatten the payload to the node.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[trchen, 2016-07-01 22:35:44]

Description was changed from

==========
Detemplatize cc property nodes

Property nodes used to be instantiation of TreeNode<T> template with different
payload. There is little gain from it (deduplicate 500 bytes of code for 3
times), while made us to type "->data." fore nearly a thousand times. Also
the extra level of indirection adds invisible mental overheads.

This CL detemplatizes TreeNode<T> and flatten the payload to the node.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Detemplatize cc property nodes

Property nodes used to be instantiation of TreeNode<T> template with different
payload. There is little gain from it (deduplicate 500 bytes of code for 3
times), while made us to type "->data." for nearly a thousand times. Also
this extra level of indirection adds invisible mental overheads.

This CL detemplatizes TreeNode<T> and flatten the payload to the node.
==========

[trchen, 2016-07-01 22:36:43]

Description was changed from

==========
Detemplatize cc property nodes

Property nodes used to be instantiation of TreeNode<T> template with different
payload. There is little gain from it (deduplicate 500 bytes of code for 3
times), while made us to type "->data." for nearly a thousand times. Also
this extra level of indirection adds invisible mental overheads.

This CL detemplatizes TreeNode<T> and flatten the payload to the node.
==========

to

==========
Detemplatize cc property nodes

Property nodes used to be instantiation of TreeNode<T> template with different
payload. There is little gain from it (deduplicate 500 bytes of code for 3
times), while made us to type "->data." for nearly a few hundred times. Also
this extra level of indirection adds invisible mental overheads.

This CL detemplatizes TreeNode<T> and flatten the payload to the node.
==========

[trchen, 2016-07-01 22:37:28]

Description was changed from

==========
Detemplatize cc property nodes

Property nodes used to be instantiation of TreeNode<T> template with different
payload. There is little gain from it (deduplicate 500 bytes of code for 3
times), while made us to type "->data." for nearly a few hundred times. Also
this extra level of indirection adds invisible mental overheads.

This CL detemplatizes TreeNode<T> and flatten the payload to the node.
==========

to

==========
Detemplatize cc property nodes

Property nodes used to be instantiation of TreeNode<T> template with different
payload. There is little gain from it (deduplicate 500 bytes of code for 3
times), while made us to type "->data." a few hundred times.
Also this extra level of indirection adds invisible mental overheads.

This CL detemplatizes TreeNode<T> and flatten the payload to the node.
==========

[trchen, 2016-07-01 22:37:28]

trchen@chromium.org changed reviewers:
+ ajuma@chromium.org, vollick@chromium.org

[trchen, 2016-07-01 22:38:33]

The CQ bit was checked by trchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-01 22:38:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 23:02:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-01 23:02:27]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Ian Vollick, 2016-07-02 01:26:06]

Some of the bot failures look real, but I like the patch. I agree that it's much
nicer without all the datas :)

https://codereview.chromium.org/2118993002/diff/1/ui/gfx/transform.h
File ui/gfx/transform.h (left):

https://codereview.chromium.org/2118993002/diff/1/ui/gfx/transform.h#oldcode71
ui/gfx/transform.h:71: ~Transform() {}
Is this related to the other changes, or is it just another cleanup?

[trchen, 2016-07-06 21:46:31]

On 2016/07/02 01:26:06, vollick wrote:
> Some of the bot failures look real, but I like the patch. I agree that it's
much
> nicer without all the datas :)
> 
> https://codereview.chromium.org/2118993002/diff/1/ui/gfx/transform.h
> File ui/gfx/transform.h (left):
> 
> https://codereview.chromium.org/2118993002/diff/1/ui/gfx/transform.h#oldcode71
> ui/gfx/transform.h:71: ~Transform() {}
> Is this related to the other changes, or is it just another cleanup?

It is needed, otherwise our clang plugin considers the default constructor being
too complex to inline.

I'm still looking at the win_clang failure. It seems to be a bug in MSVC or its
STL. Trying to figure out the best way to workaround it.

[trchen, 2016-07-06 22:26:50]

Description was changed from

==========
Detemplatize cc property nodes

Property nodes used to be instantiation of TreeNode<T> template with different
payload. There is little gain from it (deduplicate 500 bytes of code for 3
times), while made us to type "->data." a few hundred times.
Also this extra level of indirection adds invisible mental overheads.

This CL detemplatizes TreeNode<T> and flatten the payload to the node.
==========

to

==========
Detemplatize cc property nodes

Property nodes used to be instantiation of TreeNode<T> template with different
payload. There is little gain from it (deduplicate 500 bytes of code for 3
times), while made us to type "->data." a few hundred times.
Also this extra level of indirection adds invisible mental overheads.

This CL detemplatizes TreeNode<T> and flatten the payload to the node.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[trchen, 2016-07-06 22:27:01]

The CQ bit was checked by trchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-06 22:27:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[trchen, 2016-07-06 22:35:35]

On 2016/07/06 21:46:31, trchen wrote:
> I'm still looking at the win_clang failure. It seems to be a bug in MSVC or
its
> STL. Trying to figure out the best way to workaround it.

Turns out it is CC_EXPORT causing the default copy assignment operator to be
instantiated every time this header gets included. The instantiation can fail
because T can be incomplete at the time.

[commit-bot: I haz the power, 2016-07-06 22:58:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-06 22:58:35]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[trchen, 2016-07-07 01:35:00]

The CQ bit was checked by trchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-07 01:35:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 01:40:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 01:40:23]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[trchen, 2016-07-07 01:50:45]

The CQ bit was checked by trchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-07 01:51:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 02:20:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 02:20:54]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[trchen, 2016-07-07 04:47:45]

The CQ bit was checked by trchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-07 04:47:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-07 06:17:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-07 06:17:16]

Dry run: This issue passed the CQ dry run.

[Ian Vollick, 2016-07-07 14:07:53]

On 2016/07/07 at 06:17:16, commit-bot wrote:
> Dry run: This issue passed the CQ dry run.

Seems pretty mechanical, and it does look nicer. lgtm!

[trchen, 2016-07-08 02:45:04]

The CQ bit was checked by trchen@chromium.org

[trchen, 2016-07-08 02:45:05]

The patchset sent to the CQ was uploaded after l-g-t-m from vollick@chromium.org
Link to the patchset: https://codereview.chromium.org/2118993002/#ps120001
(title: "rebase")

[commit-bot: I haz the power, 2016-07-08 02:45:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 09:47:17]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-07-08 09:49:24]

Description was changed from

==========
Detemplatize cc property nodes

Property nodes used to be instantiation of TreeNode<T> template with different
payload. There is little gain from it (deduplicate 500 bytes of code for 3
times), while made us to type "->data." a few hundred times.
Also this extra level of indirection adds invisible mental overheads.

This CL detemplatizes TreeNode<T> and flatten the payload to the node.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Detemplatize cc property nodes

Property nodes used to be instantiation of TreeNode<T> template with different
payload. There is little gain from it (deduplicate 500 bytes of code for 3
times), while made us to type "->data." a few hundred times.
Also this extra level of indirection adds invisible mental overheads.

This CL detemplatizes TreeNode<T> and flatten the payload to the node.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/dba8b150955e55508ca018ab721c14dba1374fd3
Cr-Commit-Position: refs/heads/master@{#404339}
==========

[commit-bot: I haz the power, 2016-07-08 09:49:25]

Patchset 7 (id:??) landed as
https://crrev.com/dba8b150955e55508ca018ab721c14dba1374fd3
Cr-Commit-Position: refs/heads/master@{#404339}