Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4100)

Unified Diff: cc/layers/scrollbar_layer_unittest.cc

Issue 2118993002: Detemplatize cc property nodes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/render_surface_impl.cc ('k') | cc/layers/viewport.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/scrollbar_layer_unittest.cc
diff --git a/cc/layers/scrollbar_layer_unittest.cc b/cc/layers/scrollbar_layer_unittest.cc
index ef16f8b49088e3ff58e3d62ec71b0710b75d0e77..6852fee6b1c9c39c9846e0e3dcc17d95b1657a7b 100644
--- a/cc/layers/scrollbar_layer_unittest.cc
+++ b/cc/layers/scrollbar_layer_unittest.cc
@@ -27,9 +27,11 @@
#include "cc/test/mock_occlusion_tracker.h"
#include "cc/test/test_task_graph_runner.h"
#include "cc/test/test_web_graphics_context_3d.h"
+#include "cc/trees/effect_node.h"
#include "cc/trees/layer_tree_host.h"
#include "cc/trees/layer_tree_impl.h"
#include "cc/trees/occlusion_tracker.h"
+#include "cc/trees/scroll_node.h"
#include "cc/trees/single_thread_proxy.h"
#include "cc/trees/tree_synchronizer.h"
#include "testing/gmock/include/gmock/gmock.h"
@@ -543,7 +545,7 @@ TEST_F(ScrollbarLayerTest, ScrollbarLayerOpacity) {
layer_tree_host_->UpdateLayers();
EffectNode* node = layer_tree_host_->property_trees()->effect_tree.Node(
scrollbar_layer->effect_tree_index());
- EXPECT_EQ(node->data.opacity, 0.f);
+ EXPECT_EQ(node->opacity, 0.f);
// This tests that the initial opacity(0) of the scrollbar gets pushed onto
// the pending tree and then onto the active tree.
@@ -555,12 +557,12 @@ TEST_F(ScrollbarLayerTest, ScrollbarLayerOpacity) {
EXPECT_TRUE(layer_tree_impl->IsPendingTree());
node = layer_tree_impl->property_trees()->effect_tree.Node(
scrollbar_layer->effect_tree_index());
- EXPECT_EQ(node->data.opacity, 0.f);
+ EXPECT_EQ(node->opacity, 0.f);
host_impl->ActivateSyncTree();
layer_tree_impl = host_impl->active_tree();
node = layer_tree_impl->property_trees()->effect_tree.Node(
scrollbar_layer->effect_tree_index());
- EXPECT_EQ(node->data.opacity, 0.f);
+ EXPECT_EQ(node->opacity, 0.f);
// This tests that activation does not change the opacity of scrollbar layer.
LayerImpl* scrollbar_layer_impl =
@@ -572,12 +574,12 @@ TEST_F(ScrollbarLayerTest, ScrollbarLayerOpacity) {
EXPECT_TRUE(layer_tree_impl->IsPendingTree());
node = layer_tree_impl->property_trees()->effect_tree.Node(
scrollbar_layer->effect_tree_index());
- EXPECT_EQ(node->data.opacity, 0.f);
+ EXPECT_EQ(node->opacity, 0.f);
host_impl->ActivateSyncTree();
layer_tree_impl = host_impl->active_tree();
node = layer_tree_impl->property_trees()->effect_tree.Node(
scrollbar_layer->effect_tree_index());
- EXPECT_EQ(node->data.opacity, 0.25f);
+ EXPECT_EQ(node->opacity, 0.25f);
}
TEST_F(ScrollbarLayerTest, ScrollbarLayerPushProperties) {
@@ -621,7 +623,7 @@ TEST_F(ScrollbarLayerTest, ScrollbarLayerPushProperties) {
EffectNode* node =
host_impl->active_tree()->property_trees()->effect_tree.Node(
scrollbar_layer->effect_tree_index());
- EXPECT_EQ(node->data.opacity, 1.f);
+ EXPECT_EQ(node->opacity, 1.f);
}
class ScrollbarLayerSolidColorThumbTest : public testing::Test {
« no previous file with comments | « cc/layers/render_surface_impl.cc ('k') | cc/layers/viewport.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698