Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 211683002: Add discard API to SkCanvas, plumb it to glDiscardFramebuffer() (Closed)

Created:
6 years, 9 months ago by bsalomon
Modified:
6 years, 9 months ago
Reviewers:
robertphillips, reed1
Visibility:
Public.

Description

Add discard API to SkCanvas, plumb it to glDiscardFramebuffer() BUG=skia:2349 Committed: http://code.google.com/p/skia/source/detail?r=13976

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : #

Patch Set 4 : discard #

Patch Set 5 : assert that clear color is pm #

Total comments: 4

Patch Set 6 : Address comments #

Patch Set 7 : move to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -58 lines) Patch
M gyp/core.gypi View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
M include/core/SkCanvas.h View 1 2 3 2 chunks +16 lines, -0 lines 0 comments Download
M include/gpu/GrColor.h View 1 2 3 4 2 chunks +30 lines, -9 lines 0 comments Download
M include/gpu/GrContext.h View 1 1 chunk +7 lines, -1 line 0 comments Download
M include/gpu/GrRenderTarget.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 3 chunks +20 lines, -17 lines 0 comments Download
M src/gpu/GrDrawTargetCaps.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 2 3 4 3 chunks +23 lines, -4 lines 0 comments Download
M src/gpu/GrRenderTarget.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 1 2 3 4 5 6 2 chunks +0 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 2 3 4 5 6 4 chunks +1 line, -4 lines 0 comments Download
M src/gpu/gl/GrGLDefines.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGpuGL.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 1 chunk +19 lines, -0 lines 0 comments Download
M src/image/SkSurface.cpp View 1 2 2 chunks +4 lines, -7 lines 0 comments Download
M src/image/SkSurface_Base.h View 1 2 3 chunks +10 lines, -10 lines 0 comments Download
M src/image/SkSurface_Gpu.cpp View 2 chunks +7 lines, -0 lines 0 comments Download
M src/image/SkSurface_Picture.cpp View 1 2 3 4 5 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
bsalomon
reed@ for the API, Surface integration. robertphillips@ for the GPU implementation.
6 years, 9 months ago (2014-03-26 21:09:17 UTC) #1
reed1
lgtm
6 years, 9 months ago (2014-03-26 21:13:59 UTC) #2
robertphillips
lgtm + minor nits https://codereview.chromium.org/211683002/diff/100001/src/core/SkCanvas.cpp File src/core/SkCanvas.cpp (right): https://codereview.chromium.org/211683002/diff/100001/src/core/SkCanvas.cpp#newcode1915 src/core/SkCanvas.cpp:1915: void SkCanvas::onDiscard() { NULL != ...
6 years, 9 months ago (2014-03-27 12:19:44 UTC) #3
bsalomon
https://codereview.chromium.org/211683002/diff/100001/src/core/SkCanvas.cpp File src/core/SkCanvas.cpp (right): https://codereview.chromium.org/211683002/diff/100001/src/core/SkCanvas.cpp#newcode1915 src/core/SkCanvas.cpp:1915: void SkCanvas::onDiscard() { On 2014/03/27 12:19:44, robertphillips wrote: > ...
6 years, 9 months ago (2014-03-27 13:13:17 UTC) #4
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 9 months ago (2014-03-28 14:36:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/211683002/120001
6 years, 9 months ago (2014-03-28 14:37:07 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 14:46:57 UTC) #7
commit-bot: I haz the power
Retried try job too often on Build-Mac10.8-Clang-x86-Release-Trybot for step(s) BuildBench, BuildEverything, BuildGm, BuildSkiaLib, BuildTests, BuildTools ...
6 years, 9 months ago (2014-03-28 14:46:57 UTC) #8
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 9 months ago (2014-03-28 15:03:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/211683002/140001
6 years, 9 months ago (2014-03-28 15:03:11 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 16:08:13 UTC) #11
Message was sent while issue was closed. 
Change committed as 13976

Powered by Google App Engine
This is Rietveld 408576698