Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 2112653002: Add static buffer support (Closed)

Created:
4 years, 5 months ago by jvanverth1
Modified:
4 years, 5 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add static buffer support Put resource tracking check in the right place BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2112653002 Committed: https://skia.googlesource.com/skia/+/a584de966a4f7ab71f3f07077cf1e226def9d730

Patch Set 1 #

Patch Set 2 : Fix indent #

Patch Set 3 : Rebase to ToT #

Patch Set 4 : Move resource check to the right place #

Patch Set 5 : Remove resource tracking changes #

Total comments: 4

Patch Set 6 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -39 lines) Patch
M src/gpu/vk/GrVkBuffer.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/vk/GrVkBuffer.cpp View 1 2 3 4 5 6 chunks +29 lines, -17 lines 0 comments Download
M src/gpu/vk/GrVkCommandBuffer.h View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M src/gpu/vk/GrVkCommandBuffer.cpp View 1 chunk +19 lines, -0 lines 0 comments Download
M src/gpu/vk/GrVkGpu.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/vk/GrVkGpu.cpp View 1 2 3 4 5 3 chunks +13 lines, -7 lines 0 comments Download
M src/gpu/vk/GrVkMemory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/vk/GrVkMemory.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M src/gpu/vk/GrVkPipelineStateDataManager.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/vk/GrVkPipelineStateDataManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/vk/GrVkResourceProvider.cpp View 1 2 3 4 3 chunks +8 lines, -7 lines 0 comments Download
M src/gpu/vk/GrVkTransferBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/vk/GrVkUniformBuffer.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
jvanverth1
4 years, 5 months ago (2016-06-30 13:24:04 UTC) #4
egdaniel
https://codereview.chromium.org/2112653002/diff/80001/src/gpu/vk/GrVkBuffer.cpp File src/gpu/vk/GrVkBuffer.cpp (right): https://codereview.chromium.org/2112653002/diff/80001/src/gpu/vk/GrVkBuffer.cpp#newcode32 src/gpu/vk/GrVkBuffer.cpp:32: case kVertex_Type: nit (from not your change), should these ...
4 years, 5 months ago (2016-06-30 13:51:19 UTC) #5
jvanverth1
https://codereview.chromium.org/2112653002/diff/80001/src/gpu/vk/GrVkBuffer.cpp File src/gpu/vk/GrVkBuffer.cpp (right): https://codereview.chromium.org/2112653002/diff/80001/src/gpu/vk/GrVkBuffer.cpp#newcode32 src/gpu/vk/GrVkBuffer.cpp:32: case kVertex_Type: On 2016/06/30 13:51:19, egdaniel wrote: > nit ...
4 years, 5 months ago (2016-06-30 14:56:38 UTC) #6
egdaniel
lgtm
4 years, 5 months ago (2016-06-30 14:58:29 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112653002/100001
4 years, 5 months ago (2016-06-30 15:04:13 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-30 15:48:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112653002/100001
4 years, 5 months ago (2016-06-30 16:09:56 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 16:11:00 UTC) #17
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/a584de966a4f7ab71f3f07077cf1e226def9d730

Powered by Google App Engine
This is Rietveld 408576698