Greatly simplify buildbot module and remove usage of master name.

Greatly simplify buildbot module and remove usage of master name.

It looks like most of the functionality in the buildbot module was
unused, dead code.

This also means that master name is not required for anything, since
actual fetching of layout test results don't use master name (because
the Google Storage directory layout doesn't include master name).

Use of master name was added in http://crrev.com/2009603004 because
at that time, getting a Build object required making a request to
build.chromium.org which required a master name. But now this is not
the case.

Committed: https://crrev.com/b0c5ab03643d15a7388ff214226df35a5d125f55
Cr-Commit-Position: refs/heads/master@{#403614}

[qyearsley, 2016-06-30 23:29:09]

Description was changed from

==========
Greatly simplify buildbot module and remove usage of master name.

It turns out that most of the functionality in the buildbot module was
unused, dead code.

This also means that master name is not required for anything, since
actual fetching of layout test results don't use master name (because
the Google Storage directory layout doesn't include master name.

BUG=
==========

to

==========
Greatly simplify buildbot module and remove usage of master name.

It looks like most of the functionality in the buildbot module was
unused, dead code.

This also means that master name is not required for anything, since
actual fetching of layout test results don't use master name (because
the Google Storage directory layout doesn't include master name).

Use of master name was added in http://crrev.com/2009603004 because
at that time, getting a Build object required making a request to
build.chromium.org which required a master name. But now this is not
the case.
==========

[qyearsley, 2016-06-30 23:29:10]

qyearsley@chromium.org changed reviewers:
+ dpranke@chromium.org, ojan@chromium.org, wkorman@chromium.org

[qyearsley, 2016-06-30 23:29:15]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-30 23:30:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 00:48:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-01 00:48:06]

Dry run: This issue passed the CQ dry run.

[wkorman, 2016-07-01 19:00:20]

lgtm

https://codereview.chromium.org/2112133002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py (left):

https://codereview.chromium.org/2112133002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py:241:
builder['is_green'] = not re.search('fail', cell.renderContents()) or \
There's no need for green-builder logic anywhere any more? Or is it handled
somewhere else now?

https://codereview.chromium.org/2112133002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot_mock.py
(left):

https://codereview.chromium.org/2112133002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot_mock.py:42:
self._revision = revision
Or specific revisions, no longer needed, or handled elsewhere/differently?

[qyearsley, 2016-07-01 19:08:06]

https://codereview.chromium.org/2112133002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py (left):

https://codereview.chromium.org/2112133002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot.py:241:
builder['is_green'] = not re.search('fail', cell.renderContents()) or \
On 2016/07/01 at 19:00:19, wkorman wrote:
> There's no need for green-builder logic anywhere any more? Or is it handled
somewhere else now?

There's no use of it in webkitpy as far as I have found -- the public functions
here aren't used anywhere else and all of the tests still pass.

In the layout test results, there is still a revision field, but I think that's
gotten locally on the builders and there's nowhere no where some code in
webkitpy is making requests to build.chromium.org to check what builders are
green, or what revision is built for a particular build.

https://codereview.chromium.org/2112133002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot_mock.py
(left):

https://codereview.chromium.org/2112133002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot_mock.py:42:
self._revision = revision
On 2016/07/01 at 19:00:20, wkorman wrote:
> Or specific revisions, no longer needed, or handled elsewhere/differently?

AFAIK, no longer needed anymore or used anymore. Chromium revision (git commit
position number) is output into the test results JSON file, but not requested
from build.chromium.org, I think.

[Dirk Pranke, 2016-07-01 22:50:21]

lgtm, nice improvements!

[qyearsley, 2016-07-02 16:41:05]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2016-07-02 16:41:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-02 16:42:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-02 16:42:40]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_gyp_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gyp_...)

[qyearsley, 2016-07-02 17:14:32]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2016-07-02 17:14:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2112133002/#ps20001
(title: "Rebased")

[commit-bot: I haz the power, 2016-07-02 17:14:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-02 18:38:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-02 18:39:02]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-02 18:40:31]

Description was changed from

==========
Greatly simplify buildbot module and remove usage of master name.

It looks like most of the functionality in the buildbot module was
unused, dead code.

This also means that master name is not required for anything, since
actual fetching of layout test results don't use master name (because
the Google Storage directory layout doesn't include master name).

Use of master name was added in http://crrev.com/2009603004 because
at that time, getting a Build object required making a request to
build.chromium.org which required a master name. But now this is not
the case.
==========

to

==========
Greatly simplify buildbot module and remove usage of master name.

It looks like most of the functionality in the buildbot module was
unused, dead code.

This also means that master name is not required for anything, since
actual fetching of layout test results don't use master name (because
the Google Storage directory layout doesn't include master name).

Use of master name was added in http://crrev.com/2009603004 because
at that time, getting a Build object required making a request to
build.chromium.org which required a master name. But now this is not
the case.

Committed: https://crrev.com/b0c5ab03643d15a7388ff214226df35a5d125f55
Cr-Commit-Position: refs/heads/master@{#403614}
==========

[commit-bot: I haz the power, 2016-07-02 18:40:32]

Patchset 2 (id:??) landed as
https://crrev.com/b0c5ab03643d15a7388ff214226df35a5d125f55
Cr-Commit-Position: refs/heads/master@{#403614}

[falken, 2016-07-04 02:05:38]

falken@chromium.org changed reviewers:
+ falken@chromium.org

[falken, 2016-07-04 02:05:39]

I can no longer run-webkit-tests after this patch:

$ third_party/WebKit/Tools/Scripts/run-webkit-tests --target=Default
...
AttributeError: 'module' object has no attribute 'chromium_buildbot_url'

[falken, 2016-07-04 03:12:42]

On 2016/07/04 02:05:39, falken wrote:
> I can no longer run-webkit-tests after this patch:
> 
> $ third_party/WebKit/Tools/Scripts/run-webkit-tests --target=Default
> ...
> AttributeError: 'module' object has no attribute 'chromium_buildbot_url'

It turns out removing *.pyc files fixes it.

[lfg, 2016-07-05 15:19:59]

On 2016/07/04 03:12:42, falken wrote:
> On 2016/07/04 02:05:39, falken wrote:
> > I can no longer run-webkit-tests after this patch:
> > 
> > $ third_party/WebKit/Tools/Scripts/run-webkit-tests --target=Default
> > ...
> > AttributeError: 'module' object has no attribute 'chromium_buildbot_url'
> 
> It turns out removing *.pyc files fixes it.

I had the same issue. Also couldn't run 'git cl upload'. Is there any way we
could have automated this cleanup with the patch?

[Dirk Pranke, 2016-07-05 16:32:36]

On 2016/07/05 15:19:59, lfg wrote:
> On 2016/07/04 03:12:42, falken wrote:
> > On 2016/07/04 02:05:39, falken wrote:
> > > I can no longer run-webkit-tests after this patch:
> > > 
> > > $ third_party/WebKit/Tools/Scripts/run-webkit-tests --target=Default
> > > ...
> > > AttributeError: 'module' object has no attribute 'chromium_buildbot_url'
> > 
> > It turns out removing *.pyc files fixes it.
> 
> I had the same issue. Also couldn't run 'git cl upload'. Is there any way we
> could have automated this cleanup with the patch?

We have presubmit checks and hooks that clean up stale .pyc files in various
places in the repo. We should check and make sure we have one for webkitpy
as well (I thought we did, but I don't remember for sure).

[qyearsley, 2016-07-05 18:35:34]

On 2016/07/05 at 16:32:36, dpranke wrote:
> On 2016/07/05 15:19:59, lfg wrote:
> > On 2016/07/04 03:12:42, falken wrote:
> > > On 2016/07/04 02:05:39, falken wrote:
> > > > I can no longer run-webkit-tests after this patch:
> > > > 
> > > > $ third_party/WebKit/Tools/Scripts/run-webkit-tests --target=Default
> > > > ...
> > > > AttributeError: 'module' object has no attribute 'chromium_buildbot_url'
> > > 
> > > It turns out removing *.pyc files fixes it.
> > 
> > I had the same issue. Also couldn't run 'git cl upload'. Is there any way we
> > could have automated this cleanup with the patch?
> 
> We have presubmit checks and hooks that clean up stale .pyc files in various
> places in the repo. We should check and make sure we have one for webkitpy
> as well (I thought we did, but I don't remember for sure).

Filed http://crbug.com/625877 for the task of making sure that stale .pyc files
are cleaned up for webkitpy.