Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py

Issue 2112133002: Greatly simplify buildbot module and remove usage of master name. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Utility functions to communicate with Rietveld.""" 5 """Utility functions to communicate with Rietveld."""
6 6
7 import collections 7 import collections
8 import json 8 import json
9 import logging 9 import logging
10 import urllib2 10 import urllib2
11 11
12 12
13 _log = logging.getLogger(__name__) 13 _log = logging.getLogger(__name__)
14 14
15 BASE_CODEREVIEW_URL = 'https://codereview.chromium.org/api' 15 BASE_CODEREVIEW_URL = 'https://codereview.chromium.org/api'
16 16
17 TryJob = collections.namedtuple('TryJob', ('builder_name', 'master_name', 'build _number')) 17 TryJob = collections.namedtuple('TryJob', ('builder_name', 'build_number'))
18 18
19 def latest_try_jobs(issue_number, builder_names, web, patchset_number=None): 19 def latest_try_jobs(issue_number, builder_names, web, patchset_number=None):
20 """Returns a list of TryJob objects for jobs on the latest patchset. 20 """Returns a list of TryJob objects for jobs on the latest patchset.
21 21
22 Args: 22 Args:
23 issue_number: A Rietveld issue number. 23 issue_number: A Rietveld issue number.
24 builder_names: Builders that we're interested in; try jobs for only 24 builder_names: Builders that we're interested in; try jobs for only
25 these builders will be listed. 25 these builders will be listed.
26 web: webkitpy.common.net.web.Web object (which can be mocked out). 26 web: webkitpy.common.net.web.Web object (which can be mocked out).
27 patchset_number: Use a specific patchset instead of the latest one. 27 patchset_number: Use a specific patchset instead of the latest one.
28 28
29 Returns: 29 Returns:
30 A list of TryJob objects; empty list if none were found. 30 A list of TryJob objects; empty list if none were found.
31 """ 31 """
32 try: 32 try:
33 if patchset_number: 33 if patchset_number:
34 url = _patchset_url(issue_number, patchset_number) 34 url = _patchset_url(issue_number, patchset_number)
35 else: 35 else:
36 url = _latest_patchset_url(issue_number, web) 36 url = _latest_patchset_url(issue_number, web)
37 patchset_data = _get_json(url, web) 37 patchset_data = _get_json(url, web)
38 except (urllib2.URLError, ValueError): 38 except (urllib2.URLError, ValueError):
39 return [] 39 return []
40 jobs = [] 40 jobs = []
41 for job in patchset_data['try_job_results']: 41 for job in patchset_data['try_job_results']:
42 if job['builder'] not in builder_names: 42 if job['builder'] not in builder_names:
43 continue 43 continue
44 # The master name may be prefixed with "master.", or possibly not;
45 # We want to normalize master name by stripping this prefix.
46 # See http://crbug.com/624545.
47 master_name = job['master']
48 if master_name.startswith('master.'):
49 master_name = master_name[len('master.'):]
50 jobs.append(TryJob( 44 jobs.append(TryJob(
51 builder_name=job['builder'], 45 builder_name=job['builder'],
52 master_name=master_name,
53 build_number=job['buildnumber'])) 46 build_number=job['buildnumber']))
54 return jobs 47 return jobs
55 48
56 49
57 def _latest_patchset_url(issue_number, web): 50 def _latest_patchset_url(issue_number, web):
58 issue_data = _get_json(_issue_url(issue_number), web) 51 issue_data = _get_json(_issue_url(issue_number), web)
59 latest_patchset_number = issue_data["patchsets"][-1] 52 latest_patchset_number = issue_data["patchsets"][-1]
60 return _patchset_url(issue_number, latest_patchset_number) 53 return _patchset_url(issue_number, latest_patchset_number)
61 54
62 55
(...skipping 24 matching lines...) Expand all
87 return '%s/%s' % (_issue_url(issue_number), patchset_number) 80 return '%s/%s' % (_issue_url(issue_number), patchset_number)
88 81
89 82
90 def get_latest_try_job_results(issue_number, web): 83 def get_latest_try_job_results(issue_number, web):
91 url = _latest_patchset_url(issue_number, web) 84 url = _latest_patchset_url(issue_number, web)
92 patchset_data = _get_json(url, web) 85 patchset_data = _get_json(url, web)
93 results = {} 86 results = {}
94 for job in patchset_data['try_job_results']: 87 for job in patchset_data['try_job_results']:
95 results[job['builder']] = job['result'] 88 results[job['builder']] = job['result']
96 return results 89 return results
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698