third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py - Issue 2112133002: Greatly simplify buildbot module and remove usage of master name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py

Issue 2112133002: Greatly simplify buildbot module and remove usage of master name. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot_unittest.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py

index 554cc4f32ef5ddcc6019dafff8c5050964444dd8..5b9b1a8ae438d02886d09fb858b88ab52c20ccbc 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py

@@ -14,7 +14,7 @@ _log = logging.getLogger(__name__)

BASE_CODEREVIEW_URL = 'https://codereview.chromium.org/api'

-TryJob = collections.namedtuple('TryJob', ('builder_name', 'master_name', 'build_number'))

+TryJob = collections.namedtuple('TryJob', ('builder_name', 'build_number'))

def latest_try_jobs(issue_number, builder_names, web, patchset_number=None):

"""Returns a list of TryJob objects for jobs on the latest patchset.

@@ -41,15 +41,8 @@ def latest_try_jobs(issue_number, builder_names, web, patchset_number=None):

for job in patchset_data['try_job_results']:

if job['builder'] not in builder_names:

continue

- # The master name may be prefixed with "master.", or possibly not;

- # We want to normalize master name by stripping this prefix.

- # See http://crbug.com/624545.

- master_name = job['master']

- if master_name.startswith('master.'):

- master_name = master_name[len('master.'):]

jobs.append(TryJob(

builder_name=job['builder'],

- master_name=master_name,

build_number=job['buildnumber']))

return jobs