third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py - Issue 2112133002: Greatly simplify buildbot module and remove usage of master name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py

Issue 2112133002: Greatly simplify buildbot module and remove usage of master name. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_from_try_jobs.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py

index d6ea216252ef2e27d58fd2775d3983c8cea8fba7..77424eec001d20a2fb320cde0bfeca53be876046 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py

@@ -69,8 +69,8 @@ class AbstractRebaseliningCommand(Command):

self._baseline_suffix_list = BASELINE_SUFFIX_LIST

self._scm_changes = {'add': [], 'delete': [], 'remove-lines': []}

- def _results_url(self, builder_name, master_name, build_number=None):

- builder = self._tool.buildbot.builder_with_name(builder_name, master_name)

+ def _results_url(self, builder_name, build_number=None):

+ builder = self._tool.buildbot.builder_with_name(builder_name)

if build_number:

build = builder.build(build_number)

return build.results_url()

@@ -98,8 +98,6 @@ class BaseInternalRebaselineCommand(AbstractRebaseliningCommand):

optparse.make_option("--test", help="Test to rebaseline."),

optparse.make_option("--build-number", default=None, type="int",

help="Optional build number; if not given, the latest build is used."),

- optparse.make_option("--master-name", default='chromium.webkit', type="str",

- help="Optional master name; if not given, a default master will be used."),

])

def _baseline_directory(self, builder_name):

@@ -227,7 +225,7 @@ class RebaselineTest(BaseInternalRebaselineCommand):

if options.results_directory:

results_url = 'file://' + options.results_directory

else:

- results_url = self._results_url(options.builder, options.master_name, build_number=options.build_number)

+ results_url = self._results_url(options.builder, build_number=options.build_number)

for suffix in self._baseline_suffix_list:

self._rebaseline_test(options.builder, options.test, suffix, results_url)