Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py

Issue 2112133002: Greatly simplify buildbot module and remove usage of master name. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py
index 9ed3e1430449eb9476fd23f23201b124a4782f7a..f4fa65598cd2b697be774781cd30a392c7ddf114 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py
@@ -26,13 +26,11 @@ class RietveldTest(unittest.TestCase):
'try_job_results': [
{
'builder': 'foo-builder',
- 'master': 'master.tryserver.foo',
'buildnumber': 10,
'result': -1
},
{
'builder': 'bar-builder',
- 'master': 'master.tryserver.bar',
'buildnumber': 50,
'results': 0
},
@@ -42,13 +40,11 @@ class RietveldTest(unittest.TestCase):
'try_job_results': [
{
'builder': 'foo-builder',
- 'master': 'master.tryserver.foo',
'buildnumber': 20,
'result': 1
},
{
'builder': 'bar-builder',
- 'master': 'master.tryserver.bar',
'buildnumber': 60,
'result': 0
},
@@ -60,7 +56,7 @@ class RietveldTest(unittest.TestCase):
def test_latest_try_jobs(self):
self.assertEqual(
latest_try_jobs(11112222, ('bar-builder', 'other-builder'), self.web),
- [TryJob('bar-builder', 'tryserver.bar', 60)])
+ [TryJob('bar-builder', 60)])
def test_latest_try_jobs_http_error(self):
def raise_error(_):
@@ -86,7 +82,7 @@ class RietveldTest(unittest.TestCase):
def test_latest_try_jobs_with_patchset(self):
self.assertEqual(
latest_try_jobs(11112222, ('bar-builder', 'other-builder'), self.web, patchset_number=2),
- [TryJob('bar-builder', 'tryserver.bar', 50)])
+ [TryJob('bar-builder', 50)])
def test_latest_try_jobs_no_relevant_builders(self):
self.assertEqual(latest_try_jobs(11112222, ('foo', 'bar'), self.web), [])

Powered by Google App Engine
This is Rietveld 408576698