[Cronet] Fix up log TAGs to be accurate and prevent future inaccuracies.

[Cronet] Fix up log TAGs to be accurate and prevent future inaccuracies.

As Cronet classes have been getting renamed we've failed to keep our
log TAGs accurate.  This change makes them accurate and attempts to
prevent future inaccuracies by using class.getSimpleName() in hopes
that a class rename will force a TAG rename.

R=xunjieli
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2109293005
Cr-Commit-Position: refs/heads/master@{#443274}
Committed: https://chromium.googlesource.com/chromium/src/+/69056e552cde6e0019daf2a1d84d8e60f5690617

[pauljensen, 2016-06-30 16:26:45]

Helen, PTAL.  I kept "cr." prefixes when it helped differentiate the name from
other Chromium objects.

[xunjieli, 2016-07-01 14:11:07]

xunjieli@chromium.org changed reviewers:
+ mef@chromium.org

[xunjieli, 2016-07-01 14:11:08]

+ Misha.

https://codereview.chromium.org/2109293005/diff/1/components/cronet/android/j...
File
components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java
(left):

https://codereview.chromium.org/2109293005/diff/1/components/cronet/android/j...
components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java:46:
static final String LOG_TAG = "ChromiumNetwork";
There was a reason that this TAG is ChromiumNetwork. I am not sure if it is
still applicable. +mef@ to comment.

[mef, 2016-07-01 15:18:18]

https://codereview.chromium.org/2109293005/diff/1/components/cronet/android/j...
File
components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java
(left):

https://codereview.chromium.org/2109293005/diff/1/components/cronet/android/j...
components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java:46:
static final String LOG_TAG = "ChromiumNetwork";
On 2016/07/01 14:11:07, xunjieli wrote:
> There was a reason that this TAG is ChromiumNetwork. I am not sure if it is
> still applicable. +mef@ to comment.

I think the reason was mostly historical (based on existing implementation).
I don't mind the rename, but I'm not sure whether class name is the right tag to
use.

2 reasons:
- Wouldn't it be useful to adjust all Cronet logging with one setting as opposed
to X class-specific settings?
- It seems that Chrome likes to prefix tags with 'cr.', should Cronet do the
same?

[pauljensen, 2016-07-01 15:35:22]

https://codereview.chromium.org/2109293005/diff/1/components/cronet/android/j...
File
components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java
(left):

https://codereview.chromium.org/2109293005/diff/1/components/cronet/android/j...
components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java:46:
static final String LOG_TAG = "ChromiumNetwork";
On 2016/07/01 15:18:18, mef wrote:
> On 2016/07/01 14:11:07, xunjieli wrote:
> > There was a reason that this TAG is ChromiumNetwork. I am not sure if it is
> > still applicable. +mef@ to comment.
> 
> I think the reason was mostly historical (based on existing implementation).
> I don't mind the rename, but I'm not sure whether class name is the right tag
to
> use.
> 
> 2 reasons:
> - Wouldn't it be useful to adjust all Cronet logging with one setting as
opposed
> to X class-specific settings?

I don't feel too strongly as there are pros and cons to both arguments:
1. using the class name is AFAIK the pattern that everyone uses.
2. using the class name makes it easy to track something down, rather than
trying to grep for a particular error message substring
3. using a more general tag like "Cronet" can lead to identical log messages in
different files that are impossible to differentiate
4. using a more general tag like "Cronet" makes it harder to know if you're
adding a log message that is identical to those in another file
5. using a more general tag like "Cronet" helps embedders know it came from
cronet, rather than trying to guess what "CronetUrlRequestContext" is

> - It seems that Chrome likes to prefix tags with 'cr.', should Cronet do the
> same?

I don't think this is common in Chrome.  It appears to be less than 10%:
616 instances of "TAG = " in Java files, and only 45 instances of "cr." in
those:
https://cs.chromium.org/search/?q=%22TAG+%3D+%22+file:java&sq=package:chromiu...
https://cs.chromium.org/search/?q=%22TAG+%3D+%22+file:java+%22cr.%22&sq=packa...

[pauljensen, 2016-07-01 15:40:42]

https://codereview.chromium.org/2109293005/diff/1/components/cronet/android/j...
File
components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java
(right):

https://codereview.chromium.org/2109293005/diff/1/components/cronet/android/j...
components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java:26:
static final String LOG_TAG = ChromiumUrlRequestContext.class.getSimpleName();
This name is too long.  Limit is 23 chars.  This is probably why it was
ChromiumNetwork previously.

[xunjieli, 2016-07-01 15:53:16]

According to docs/android_logging.md, it looks like that the cr. prefix will be
prepended to the TAG
(https://cs.chromium.org/chromium/src/base/android/java/src/org/chromium/base/...).
If my reading of the code is correct, I think we can get rid of the cr. tags in
Cronet for code consistency.

[pauljensen, 2016-07-01 15:57:26]

On 2016/07/01 15:53:16, xunjieli wrote:
> According to docs/android_logging.md, it looks like that the cr. prefix will
be
> prepended to the TAG
>
(https://cs.chromium.org/chromium/src/base/android/java/src/org/chromium/base/...).
> If my reading of the code is correct, I think we can get rid of the cr. tags
in
> Cronet for code consistency.

According to my grepping, in Cronet 9 files use base.Log while 12 use
android.util.Log.  I assume the 12 using android.util.Log don't get the "cr."
prefix.

[xunjieli, 2016-07-01 16:21:24]

On 2016/07/01 15:57:26, pauljensen wrote:
> On 2016/07/01 15:53:16, xunjieli wrote:
> > According to docs/android_logging.md, it looks like that the cr. prefix will
> be
> > prepended to the TAG
> >
>
(https://cs.chromium.org/chromium/src/base/android/java/src/org/chromium/base/...).
> > If my reading of the code is correct, I think we can get rid of the cr. tags
> in
> > Cronet for code consistency.
> 
> According to my grepping, in Cronet 9 files use base.Log while 12 use
> android.util.Log.  I assume the 12 using android.util.Log don't get the "cr."
> prefix.

Ah, I see. There is a crbug to change android.util.Log to base.Log, do you want
to do that in this CL as well? If not, that's fine too. lgtm

[pauljensen, 2016-07-01 18:15:22]

On 2016/07/01 16:21:24, xunjieli wrote:
> On 2016/07/01 15:57:26, pauljensen wrote:
> > On 2016/07/01 15:53:16, xunjieli wrote:
> > > According to docs/android_logging.md, it looks like that the cr. prefix
will
> > be
> > > prepended to the TAG
> > >
> >
>
(https://cs.chromium.org/chromium/src/base/android/java/src/org/chromium/base/...).
> > > If my reading of the code is correct, I think we can get rid of the cr.
tags
> > in
> > > Cronet for code consistency.
> > 
> > According to my grepping, in Cronet 9 files use base.Log while 12 use
> > android.util.Log.  I assume the 12 using android.util.Log don't get the
"cr."
> > prefix.
> 
> Ah, I see. There is a crbug to change android.util.Log to base.Log, do you
want
> to do that in this CL as well? If not, that's fine too. lgtm

We cannot use base from Cronet API.

[mef, 2016-07-13 19:15:58]

https://codereview.chromium.org/2109293005/diff/1/components/cronet/android/j...
File
components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java
(left):

https://codereview.chromium.org/2109293005/diff/1/components/cronet/android/j...
components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java:46:
static final String LOG_TAG = "ChromiumNetwork";
On 2016/07/01 15:35:22, pauljensen wrote:
> On 2016/07/01 15:18:18, mef wrote:
> > On 2016/07/01 14:11:07, xunjieli wrote:
> > > There was a reason that this TAG is ChromiumNetwork. I am not sure if it
is
> > > still applicable. +mef@ to comment.
> > 
> > I think the reason was mostly historical (based on existing implementation).
> > I don't mind the rename, but I'm not sure whether class name is the right
tag
> to
> > use.
> > 
> > 2 reasons:
> > - Wouldn't it be useful to adjust all Cronet logging with one setting as
> opposed
> > to X class-specific settings?
> 
> I don't feel too strongly as there are pros and cons to both arguments:
> 1. using the class name is AFAIK the pattern that everyone uses.
> 2. using the class name makes it easy to track something down, rather than
> trying to grep for a particular error message substring
> 3. using a more general tag like "Cronet" can lead to identical log messages
in
> different files that are impossible to differentiate
> 4. using a more general tag like "Cronet" makes it harder to know if you're
> adding a log message that is identical to those in another file
> 5. using a more general tag like "Cronet" helps embedders know it came from
> cronet, rather than trying to guess what "CronetUrlRequestContext" is

Acknowledged. I don't feel strongly either, and following common pattern sgtm.

> 
> > - It seems that Chrome likes to prefix tags with 'cr.', should Cronet do the
> > same?
> 
> I don't think this is common in Chrome.  It appears to be less than 10%:
> 616 instances of "TAG = " in Java files, and only 45 instances of "cr." in
> those:
>
https://cs.chromium.org/search/?q=%22TAG+%3D+%22+file:java&sq=package:chromiu...
>
https://cs.chromium.org/search/?q=%22TAG+%3D+%22+file:java+%22cr.%22&sq=packa...

Missing "cr_" is added by org.chromium.base.Log:
https://cs.chromium.org/chromium/src/base/android/java/src/org/chromium/base/...

I think we should drop explicit "cr." from our code, and use
org.chromium.base.Log in implementation. WDYT?

https://codereview.chromium.org/2109293005/diff/20001/components/cronet/andro...
File
components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java
(right):

https://codereview.chromium.org/2109293005/diff/20001/components/cronet/andro...
components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java:26:
static final String LOG_TAG = "ChromiumUrlRequestCont";
This is legacy api, should we leave it alone?

https://codereview.chromium.org/2109293005/diff/20001/components/cronet/andro...
File
components/cronet/android/java/src/org/chromium/net/CronetLibraryLoader.java
(right):

https://codereview.chromium.org/2109293005/diff/20001/components/cronet/andro...
components/cronet/android/java/src/org/chromium/net/CronetLibraryLoader.java:12:
import org.chromium.base.Log;
Some implementation modules use android.util.Log, while others use
org.chromium.base.Log.

We can't use org.chromium.base.Log in api, but in implementation we should be
consistent.

https://codereview.chromium.org/2109293005/diff/20001/components/cronet/andro...
File
components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java
(right):

https://codereview.chromium.org/2109293005/diff/20001/components/cronet/andro...
components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java:37:
private static final String TAG = "cr." +
CronetHttpURLConnection.class.getSimpleName();
why add 'cr.' here but not elsewhere? I think import org.chromium.base.Log does
it internally anyway.

[pauljensen, 2016-08-17 11:58:33]

PTAL, thanks!

https://codereview.chromium.org/2109293005/diff/1/components/cronet/android/j...
File
components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java
(left):

https://codereview.chromium.org/2109293005/diff/1/components/cronet/android/j...
components/cronet/android/java/src/org/chromium/net/CronetUrlRequestContext.java:46:
static final String LOG_TAG = "ChromiumNetwork";
On 2016/07/13 19:15:58, mef (OOO Aug 15 - Aug 19) wrote:
> On 2016/07/01 15:35:22, pauljensen wrote:
> > On 2016/07/01 15:18:18, mef wrote:
> > > On 2016/07/01 14:11:07, xunjieli wrote:
> > > > There was a reason that this TAG is ChromiumNetwork. I am not sure if it
> is
> > > > still applicable. +mef@ to comment.
> > > 
> > > I think the reason was mostly historical (based on existing
implementation).
> > > I don't mind the rename, but I'm not sure whether class name is the right
> tag
> > to
> > > use.
> > > 
> > > 2 reasons:
> > > - Wouldn't it be useful to adjust all Cronet logging with one setting as
> > opposed
> > > to X class-specific settings?
> > 
> > I don't feel too strongly as there are pros and cons to both arguments:
> > 1. using the class name is AFAIK the pattern that everyone uses.
> > 2. using the class name makes it easy to track something down, rather than
> > trying to grep for a particular error message substring
> > 3. using a more general tag like "Cronet" can lead to identical log messages
> in
> > different files that are impossible to differentiate
> > 4. using a more general tag like "Cronet" makes it harder to know if you're
> > adding a log message that is identical to those in another file
> > 5. using a more general tag like "Cronet" helps embedders know it came from
> > cronet, rather than trying to guess what "CronetUrlRequestContext" is
> 
> Acknowledged. I don't feel strongly either, and following common pattern sgtm.
> 
> > 
> > > - It seems that Chrome likes to prefix tags with 'cr.', should Cronet do
the
> > > same?
> > 
> > I don't think this is common in Chrome.  It appears to be less than 10%:
> > 616 instances of "TAG = " in Java files, and only 45 instances of "cr." in
> > those:
> >
>
https://cs.chromium.org/search/?q=%22TAG+%3D+%22+file:java&sq=package:chromiu...
> >
>
https://cs.chromium.org/search/?q=%22TAG+%3D+%22+file:java+%22cr.%22&sq=packa...
> 
> Missing "cr_" is added by org.chromium.base.Log:
>
https://cs.chromium.org/chromium/src/base/android/java/src/org/chromium/base/...
> 
> I think we should drop explicit "cr." from our code, and use
> org.chromium.base.Log in implementation. WDYT?

Done.

https://codereview.chromium.org/2109293005/diff/20001/components/cronet/andro...
File
components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java
(right):

https://codereview.chromium.org/2109293005/diff/20001/components/cronet/andro...
components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java:26:
static final String LOG_TAG = "ChromiumUrlRequestCont";
On 2016/07/13 19:15:58, mef (OOO Aug 15 - Aug 19) wrote:
> This is legacy api, should we leave it alone?

I feel like we should fix it too.  Until we remove the legacy API entirely I
think we need to maintain it at a minimal level as it is still in use.

https://codereview.chromium.org/2109293005/diff/20001/components/cronet/andro...
File
components/cronet/android/java/src/org/chromium/net/CronetLibraryLoader.java
(right):

https://codereview.chromium.org/2109293005/diff/20001/components/cronet/andro...
components/cronet/android/java/src/org/chromium/net/CronetLibraryLoader.java:12:
import org.chromium.base.Log;
On 2016/07/13 19:15:58, mef (OOO Aug 15 - Aug 19) wrote:
> Some implementation modules use android.util.Log, while others use
> org.chromium.base.Log.
> 
> We can't use org.chromium.base.Log in api, but in implementation we should be
> consistent.

Done.

https://codereview.chromium.org/2109293005/diff/20001/components/cronet/andro...
File
components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java
(right):

https://codereview.chromium.org/2109293005/diff/20001/components/cronet/andro...
components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java:37:
private static final String TAG = "cr." +
CronetHttpURLConnection.class.getSimpleName();
On 2016/07/13 19:15:58, mef (OOO Aug 15 - Aug 19) wrote:
> why add 'cr.' here but not elsewhere? I think import org.chromium.base.Log
does
> it internally anyway.

Removed, done.

[pauljensen, 2017-01-11 15:47:23]

Friendly ping...it's been nearly 5 months :)

[xunjieli, 2017-01-11 15:49:00]

On 2017/01/11 15:47:23, pauljensen wrote:
> Friendly ping...it's been nearly 5 months :)

I guess you are not waiting on me, since I've l-g-t-m-ed :)

[chromium-reviews, 2017-01-11 15:49:35]

Sorry, looking.

On Wed, Jan 11, 2017 at 10:49 AM, <xunjieli@chromium.org> wrote:

> On 2017/01/11 15:47:23, pauljensen wrote:
> > Friendly ping...it's been nearly 5 months :)
>
> I guess you are not waiting on me, since I've l-g-t-m-ed :)
>
> https://codereview.chromium.org/2109293005/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[mef, 2017-01-11 17:14:30]

lgtm mod qq

https://codereview.chromium.org/2109293005/diff/80001/components/cronet/andro...
File
components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java
(right):

https://codereview.chromium.org/2109293005/diff/80001/components/cronet/andro...
components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java:16:
import org.chromium.base.Log;
should sample app use chromium log or rather android log?

[pauljensen, 2017-01-12 02:34:04]

Description was changed from

==========
[Cronet] Fix up log TAGs to be accurate and prevent future inaccuracies.

As Cronet classes have been getting renamed we've failed to keep our
log TAGs accurate.  This change makes them accurate and attempts to
prevent future inaccuracies by using class.getSimpleName() in hopes
that a class rename will force a TAG rename.

R=xunjieli
==========

to

==========
[Cronet] Fix up log TAGs to be accurate and prevent future inaccuracies.

As Cronet classes have been getting renamed we've failed to keep our
log TAGs accurate.  This change makes them accurate and attempts to
prevent future inaccuracies by using class.getSimpleName() in hopes
that a class rename will force a TAG rename.

R=xunjieli
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[pauljensen, 2017-01-12 02:56:58]

PTAL at the last two patch sets.

https://codereview.chromium.org/2109293005/diff/80001/components/cronet/andro...
File
components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java
(right):

https://codereview.chromium.org/2109293005/diff/80001/components/cronet/andro...
components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java:16:
import org.chromium.base.Log;
On 2017/01/11 17:14:29, mef wrote:
> should sample app use chromium log or rather android log?

Yes, it should.  Done.

[mef, 2017-01-12 15:40:55]

lgtm given that my concerns are limited to sample app.

https://codereview.chromium.org/2109293005/diff/140001/components/cronet/andr...
File
components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java
(right):

https://codereview.chromium.org/2109293005/diff/140001/components/cronet/andr...
components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java:57:
Log.i(TAG, "*** Headers Are *** " + info.getAllHeaders());
That's interesting. What if headers contain some formatting characters?

https://codereview.chromium.org/2109293005/diff/140001/components/cronet/andr...
components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java:80:
+ ", total received bytes is " + info.getReceivedByteCount());
This looks fine, but why?

https://codereview.chromium.org/2109293005/diff/140001/components/cronet/andr...
components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java:167:
Log.i(TAG, "Cronet started: " + url);
Same here. What if url contains format specifiers?

[pauljensen, 2017-01-12 16:27:36]

On 2017/01/12 15:40:55, mef wrote:
> lgtm given that my concerns are limited to sample app.
> 
>
https://codereview.chromium.org/2109293005/diff/140001/components/cronet/andr...
> File
>
components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java
> (right):
> 
>
https://codereview.chromium.org/2109293005/diff/140001/components/cronet/andr...
>
components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java:57:
> Log.i(TAG, "*** Headers Are *** " + info.getAllHeaders());
> That's interesting. What if headers contain some formatting characters?
> 
>
https://codereview.chromium.org/2109293005/diff/140001/components/cronet/andr...
>
components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java:80:
> + ", total received bytes is " + info.getReceivedByteCount());
> This looks fine, but why?
> 
>
https://codereview.chromium.org/2109293005/diff/140001/components/cronet/andr...
>
components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java:167:
> Log.i(TAG, "Cronet started: " + url);
> Same here. What if url contains format specifiers?

Unlike Chromium's Log, Android's does not take a formatting String and
varargs...It just takes a String.

[mef, 2017-01-12 16:41:12]

On 2017/01/12 16:27:36, pauljensen wrote:
> On 2017/01/12 15:40:55, mef wrote:
> > lgtm given that my concerns are limited to sample app.
> > 
> >
>
https://codereview.chromium.org/2109293005/diff/140001/components/cronet/andr...
> > File
> >
>
components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java
> > (right):
> > 
> >
>
https://codereview.chromium.org/2109293005/diff/140001/components/cronet/andr...
> >
>
components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java:57:
> > Log.i(TAG, "*** Headers Are *** " + info.getAllHeaders());
> > That's interesting. What if headers contain some formatting characters?
> > 
> >
>
https://codereview.chromium.org/2109293005/diff/140001/components/cronet/andr...
> >
>
components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java:80:
> > + ", total received bytes is " + info.getReceivedByteCount());
> > This looks fine, but why?
> > 
> >
>
https://codereview.chromium.org/2109293005/diff/140001/components/cronet/andr...
> >
>
components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java:167:
> > Log.i(TAG, "Cronet started: " + url);
> > Same here. What if url contains format specifiers?
> 
> Unlike Chromium's Log, Android's does not take a formatting String and
> varargs...It just takes a String.

Ah, perfect! LGTM

[pauljensen, 2017-01-12 16:47:54]

The CQ bit was checked by pauljensen@chromium.org

[pauljensen, 2017-01-12 16:47:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
xunjieli@chromium.org
Link to the patchset: https://codereview.chromium.org/2109293005/#ps140001
(title: "switch sample to android.util.Log")

[commit-bot: I haz the power, 2017-01-12 16:48:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 17:19:17]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1484239674549290,
"parent_rev": "3afb7e7da06df087b3e9fac2ae68593f75a051ed", "commit_rev":
"69056e552cde6e0019daf2a1d84d8e60f5690617"}

[commit-bot: I haz the power, 2017-01-12 17:19:47]

Description was changed from

==========
[Cronet] Fix up log TAGs to be accurate and prevent future inaccuracies.

As Cronet classes have been getting renamed we've failed to keep our
log TAGs accurate.  This change makes them accurate and attempts to
prevent future inaccuracies by using class.getSimpleName() in hopes
that a class rename will force a TAG rename.

R=xunjieli
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
[Cronet] Fix up log TAGs to be accurate and prevent future inaccuracies.

As Cronet classes have been getting renamed we've failed to keep our
log TAGs accurate.  This change makes them accurate and attempts to
prevent future inaccuracies by using class.getSimpleName() in hopes
that a class rename will force a TAG rename.

R=xunjieli
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2109293005
Cr-Commit-Position: refs/heads/master@{#443274}
Committed:
https://chromium.googlesource.com/chromium/src/+/69056e552cde6e0019daf2a1d84d...
==========

[commit-bot: I haz the power, 2017-01-12 17:19:48]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/69056e552cde6e0019daf2a1d84d...