components/cronet/android/java/src/org/chromium/net/impl/CronetUploadDataStream.java - Issue 2109293005: [Cronet] Fix up log TAGs to be accurate and prevent future inaccuracies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/impl/CronetUploadDataStream.java

Issue 2109293005: [Cronet] Fix up log TAGs to be accurate and prevent future inaccuracies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: switch sample to android.util.Log Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/impl/CronetLibraryLoader.java ('k') | components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java » ('j') | components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/impl/CronetUploadDataStream.java

diff --git a/components/cronet/android/java/src/org/chromium/net/impl/CronetUploadDataStream.java b/components/cronet/android/java/src/org/chromium/net/impl/CronetUploadDataStream.java

index 824ae87781ad7c22b2a27cddc8b40498a75a5b15..6e0864ab416d1fff3e733a5954f5b6ab5a8770eb 100644

--- a/components/cronet/android/java/src/org/chromium/net/impl/CronetUploadDataStream.java

+++ b/components/cronet/android/java/src/org/chromium/net/impl/CronetUploadDataStream.java

@@ -5,8 +5,8 @@

package org.chromium.net.impl;

import android.annotation.SuppressLint;

-import android.util.Log;

+import org.chromium.base.Log;

import org.chromium.base.VisibleForTesting;

import org.chromium.base.annotations.CalledByNative;

import org.chromium.base.annotations.JNINamespace;

@@ -33,7 +33,7 @@ import javax.annotation.concurrent.GuardedBy;

@JNINamespace("cronet")

@VisibleForTesting

public final class CronetUploadDataStream extends UploadDataSink {

- private static final String TAG = "CronetUploadDataStream";

+ private static final String TAG = CronetUploadDataStream.class.getSimpleName();

// These are never changed, once a request starts.

private final Executor mExecutor;

private final VersionSafeCallbacks.UploadDataProviderWrapper mDataProvider;