components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java - Issue 2109293005: [Cronet] Fix up log TAGs to be accurate and prevent future inaccuracies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java

Issue 2109293005: [Cronet] Fix up log TAGs to be accurate and prevent future inaccuracies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: switch sample to android.util.Log Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/impl/CronetUploadDataStream.java ('k') | components/cronet/android/java/src/org/chromium/net/impl/JavaUrlRequest.java » ('j') | components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java

diff --git a/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java b/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java

index 4db889ed132654998f4b3d9e3406576fbab8c574..55afce4272c2a8ced1a81060ce5aac2a91246c84 100644

--- a/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java

+++ b/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java

@@ -8,8 +8,8 @@ import android.os.ConditionVariable;

import android.os.Handler;

import android.os.Looper;

import android.os.Process;

-import android.util.Log;

+import org.chromium.base.Log;

import org.chromium.base.ObserverList;

import org.chromium.base.VisibleForTesting;

import org.chromium.base.annotations.CalledByNative;

@@ -52,7 +52,7 @@ public class CronetUrlRequestContext extends CronetEngineBase {

private static final int LOG_NONE = 3; // LOG(FATAL), no VLOG.

private static final int LOG_DEBUG = -1; // LOG(FATAL...INFO), VLOG(1)

private static final int LOG_VERBOSE = -2; // LOG(FATAL...INFO), VLOG(2)

- static final String LOG_TAG = "ChromiumNetwork";

+ static final String LOG_TAG = CronetUrlRequestContext.class.getSimpleName();

/**

* Synchronize access to mUrlRequestContextAdapter and shutdown routine.