Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Unified Diff: components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java

Issue 2109293005: [Cronet] Fix up log TAGs to be accurate and prevent future inaccuracies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: switch sample to android.util.Log Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java
diff --git a/components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java b/components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java
index cbd5926972326768e5ca659ad8a85998b074dfa0..fd2128e0c2d733e31ba5bcbcefeb849af0158158 100644
--- a/components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java
+++ b/components/cronet/android/sample/src/org/chromium/cronet_sample_apk/CronetSampleActivity.java
@@ -8,12 +8,12 @@ import android.app.Activity;
import android.content.DialogInterface;
import android.os.Bundle;
import android.support.v7.app.AlertDialog;
+import android.util.Log;
import android.view.LayoutInflater;
import android.view.View;
import android.widget.EditText;
import android.widget.TextView;
-import org.chromium.base.Log;
import org.chromium.net.CronetEngine;
import org.chromium.net.CronetException;
import org.chromium.net.UploadDataProviders;
@@ -32,7 +32,7 @@ import java.util.concurrent.Executors;
* Activity for managing the Cronet Sample.
*/
public class CronetSampleActivity extends Activity {
- private static final String TAG = "CronetSample";
+ private static final String TAG = CronetSampleActivity.class.getSimpleName();
private CronetEngine mCronetEngine;
@@ -54,7 +54,7 @@ public class CronetSampleActivity extends Activity {
@Override
public void onResponseStarted(UrlRequest request, UrlResponseInfo info) {
Log.i(TAG, "****** Response Started ******");
- Log.i(TAG, "*** Headers Are *** %s", info.getAllHeaders());
+ Log.i(TAG, "*** Headers Are *** " + info.getAllHeaders());
mef 2017/01/12 15:40:55 That's interesting. What if headers contain some f
request.read(ByteBuffer.allocateDirect(32 * 1024));
}
@@ -63,7 +63,7 @@ public class CronetSampleActivity extends Activity {
public void onReadCompleted(
UrlRequest request, UrlResponseInfo info, ByteBuffer byteBuffer) {
byteBuffer.flip();
- Log.i(TAG, "****** onReadCompleted ******%s", byteBuffer);
+ Log.i(TAG, "****** onReadCompleted ******" + byteBuffer);
try {
mReceiveChannel.write(byteBuffer);
@@ -76,8 +76,8 @@ public class CronetSampleActivity extends Activity {
@Override
public void onSucceeded(UrlRequest request, UrlResponseInfo info) {
- Log.i(TAG, "****** Request Completed, status code is %d, total received bytes is %d",
- info.getHttpStatusCode(), info.getReceivedByteCount());
+ Log.i(TAG, "****** Request Completed, status code is " + info.getHttpStatusCode()
+ + ", total received bytes is " + info.getReceivedByteCount());
mef 2017/01/12 15:40:55 This looks fine, but why?
final String receivedData = mBytesReceived.toString();
final String url = info.getUrl();
@@ -93,7 +93,7 @@ public class CronetSampleActivity extends Activity {
@Override
public void onFailed(UrlRequest request, UrlResponseInfo info, CronetException error) {
- Log.i(TAG, "****** onFailed, error is: %s", error.getMessage());
+ Log.i(TAG, "****** onFailed, error is: " + error.getMessage());
final String url = mUrl;
final String text = "Failed " + mUrl + " (" + error.getMessage() + ")";
@@ -164,7 +164,7 @@ public class CronetSampleActivity extends Activity {
}
private void startWithURL(String url, String postData) {
- Log.i(TAG, "Cronet started: %s", url);
+ Log.i(TAG, "Cronet started: " + url);
mef 2017/01/12 15:40:55 Same here. What if url contains format specifiers?
mUrl = url;
Executor executor = Executors.newSingleThreadExecutor();

Powered by Google App Engine
This is Rietveld 408576698