Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 2108623005: extensions: Change auto to not deduce raw pointers. (Closed)

Created:
4 years, 5 months ago by vmpstr
Modified:
4 years, 5 months ago
Reviewers:
danakj, benwells, dcheng
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

extensions: Change auto to not deduce raw pointers. This patch updates the code to prevent auto deducing to a raw pointer. R=benwells@chromium.org, danakj, dcheng BUG=554600 Committed: https://crrev.com/63daf7ca9ccff9c04a584cb97237ee0eb6c13fa7 Cr-Commit-Position: refs/heads/master@{#403298}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -33 lines) Patch
M extensions/browser/api/serial/serial_apitest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/event_router.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/extension_navigation_throttle.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/guest_view/extension_options/extension_options_guest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/guest_view/extensions_guest_view_message_filter.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M extensions/browser/value_store/leveldb_value_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M extensions/test/test_extensions_client.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
vmpstr
Please take a look.
4 years, 5 months ago (2016-06-28 21:24:17 UTC) #3
danakj
LGTM
4 years, 5 months ago (2016-06-28 22:15:26 UTC) #4
benwells
lgtm
4 years, 5 months ago (2016-06-29 02:07:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108623005/1
4 years, 5 months ago (2016-06-30 20:39:55 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 21:37:42 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 21:38:00 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 21:40:15 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/63daf7ca9ccff9c04a584cb97237ee0eb6c13fa7
Cr-Commit-Position: refs/heads/master@{#403298}

Powered by Google App Engine
This is Rietveld 408576698