Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: extensions/browser/guest_view/extensions_guest_view_message_filter.cc

Issue 2108623005: extensions: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/extensions_guest_view_message_filter.cc
diff --git a/extensions/browser/guest_view/extensions_guest_view_message_filter.cc b/extensions/browser/guest_view/extensions_guest_view_message_filter.cc
index 9bf71d146ea3a0a6958d4143e8fc70939f3b36af..9dea442edf213b69d205ac770f3f5194607f7add 100644
--- a/extensions/browser/guest_view/extensions_guest_view_message_filter.cc
+++ b/extensions/browser/guest_view/extensions_guest_view_message_filter.cc
@@ -76,7 +76,7 @@ bool ExtensionsGuestViewMessageFilter::OnMessageReceived(
GuestViewManager* ExtensionsGuestViewMessageFilter::
GetOrCreateGuestViewManager() {
- auto manager = GuestViewManager::FromBrowserContext(browser_context_);
+ auto* manager = GuestViewManager::FromBrowserContext(browser_context_);
if (!manager) {
manager = GuestViewManager::CreateWithDelegate(
browser_context_,
@@ -104,10 +104,10 @@ void ExtensionsGuestViewMessageFilter::OnCreateMimeHandlerViewGuest(
int element_instance_id,
const gfx::Size& element_size) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
- auto manager = GetOrCreateGuestViewManager();
+ auto* manager = GetOrCreateGuestViewManager();
- auto rfh = RenderFrameHost::FromID(render_process_id_, render_frame_id);
- auto embedder_web_contents = WebContents::FromRenderFrameHost(rfh);
+ auto* rfh = RenderFrameHost::FromID(render_process_id_, render_frame_id);
+ auto* embedder_web_contents = WebContents::FromRenderFrameHost(rfh);
if (!embedder_web_contents)
return;
@@ -135,15 +135,15 @@ void ExtensionsGuestViewMessageFilter::OnResizeGuest(
int render_frame_id,
int element_instance_id,
const gfx::Size& new_size) {
- auto manager = GuestViewManager::FromBrowserContext(browser_context_);
+ auto* manager = GuestViewManager::FromBrowserContext(browser_context_);
// We should have a GuestViewManager at this point. If we don't then the
// embedder is misbehaving.
if (!manager)
return;
- auto guest_web_contents =
+ auto* guest_web_contents =
manager->GetGuestByInstanceID(render_process_id_, element_instance_id);
- auto mhvg = MimeHandlerViewGuest::FromWebContents(guest_web_contents);
+ auto* mhvg = MimeHandlerViewGuest::FromWebContents(guest_web_contents);
if (!mhvg)
return;
@@ -159,20 +159,20 @@ void ExtensionsGuestViewMessageFilter::MimeHandlerViewGuestCreatedCallback(
int embedder_render_frame_id,
const gfx::Size& element_size,
WebContents* web_contents) {
- auto guest_view = MimeHandlerViewGuest::FromWebContents(web_contents);
+ auto* guest_view = MimeHandlerViewGuest::FromWebContents(web_contents);
if (!guest_view)
return;
int guest_instance_id = guest_view->guest_instance_id();
- auto rfh = RenderFrameHost::FromID(embedder_render_process_id,
- embedder_render_frame_id);
+ auto* rfh = RenderFrameHost::FromID(embedder_render_process_id,
+ embedder_render_frame_id);
if (!rfh)
return;
base::DictionaryValue attach_params;
attach_params.SetInteger(guest_view::kElementWidth, element_size.width());
attach_params.SetInteger(guest_view::kElementHeight, element_size.height());
- auto manager = GuestViewManager::FromBrowserContext(browser_context_);
+ auto* manager = GuestViewManager::FromBrowserContext(browser_context_);
CHECK(manager);
manager->AttachGuest(embedder_render_process_id,
element_instance_id,

Powered by Google App Engine
This is Rietveld 408576698